refactor(ast): rename #[estree(add_entry)] to #[estree(add_fields)]

[overlookmotel]

#8921 introduced attribute to add extra fields to a struct in ESTree AST #[estree(add_entry(...))]. Rename it to #[estree(add_fields(...))], as that's more descriptive of what it does.

[overlookmotel]

• refactor(ast): rename #[estree(add_entry)] to #[estree(add_fields)] #8926 👈 (View in Graphite)
• refactor(ast_tools): store lists as Vecs not Option<Vec>s #8925
• refactor(ast_tools): add helper methods to AttrPartListElement #8924
• refactor(ast_tools): make AttrPart::List never empty #8923
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Performance Report

Merging #8926 will not alter performance

_{Comparing 02-06-refactor_ast_rename_estree_add_entry_to_estree_add_fields_ (647a288) with main (4a723f1)}

Summary

✅ 33 untouched benchmarks

[overlookmotel]

@hi-ogawa It'd be ideal if we could specify the name, value, and TS type for extra fields in one place, instead of the repetition in #[estree(add_fields(blah = Whatever), add_ts("blah: Whatever"))].

But I can't see a good way to encode that in attributes right now. We can revisit this. But regardless, the functionality provided by #[estree(add_fields)] is a good addition. Thank you.

[Boshen]

Merge activity

• Feb 6, 10:07 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Feb 6, 10:07 AM EST: A user added this pull request to the Graphite merge queue.
• Feb 6, 10:29 AM EST: A user merged this pull request with the Graphite merge queue.