-
-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ast): estree compat MemberExpression
#8921
fix(ast): estree compat MemberExpression
#8921
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
CodSpeed Performance ReportMerging #8921 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've pushed a few commits purely for code style nits. I'll follow up with a PR for more substantive changes. But yes, nice! We need an #[estree(add_entry)]
attribute. This will be useful for other types too.
Part of #2854
I added a bit weird macro
add_entry(computed = true)
to add constant. Likely this is not the best way. I would appreciate any suggestion for a better approach 🙏