Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ast): estree compat MemberExpression #8921

Merged

Conversation

hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Feb 6, 2025

Part of #2854

I added a bit weird macro add_entry(computed = true) to add constant. Likely this is not the best way. I would appreciate any suggestion for a better approach 🙏

Copy link

graphite-app bot commented Feb 6, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-ast Area - AST A-ast-tools Area - AST tools C-bug Category - Bug labels Feb 6, 2025
@hi-ogawa hi-ogawa marked this pull request as ready for review February 6, 2025 10:29
Copy link

codspeed-hq bot commented Feb 6, 2025

CodSpeed Performance Report

Merging #8921 will not alter performance

Comparing hi-ogawa:fix-estree-compat-member-expression (4a43e01) with main (6942d2d)

Summary

✅ 33 untouched benchmarks

Copy link
Contributor

@overlookmotel overlookmotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pushed a few commits purely for code style nits. I'll follow up with a PR for more substantive changes. But yes, nice! We need an #[estree(add_entry)] attribute. This will be useful for other types too.

@overlookmotel overlookmotel merged commit e30cf6a into oxc-project:main Feb 6, 2025
26 checks passed
graphite-app bot pushed a commit that referenced this pull request Feb 6, 2025
…]` (#8926)

#8921 introduced attribute to add extra fields to a struct in ESTree AST `#[estree(add_entry(...))]`. Rename it to `#[estree(add_fields(...))]`, as that's more descriptive of what it does.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ast Area - AST A-ast-tools Area - AST tools C-bug Category - Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants