[tests-only] [full-ci] Add acceptance tests

[phil-davis]

The PHP unit tests were passing both before and after PR #817 - so the unit tests were not effective in finding the problem with code after the Guzzle7 update in core. See issue #1029

To cover the real Guzzle client code that lists available apps and downloads app tarballs from the market-place, we really have to do real requests to the market-place. I looked at the unit tests and it didn't look like it would be easy/possible to mock out stuff while still actually covering the things that might go wrong.

So I have added acceptance tests. The downside is that they require the live production market-place server to be up. So they might sometimes fail if the market-place server is down (for maintenance or broken or...) The tests only run in the CI of this app, so it is not going to be an issue for regular core... CI.

I locally tried reverting the code fix in PR #817 and running the acceptance tests. I get:

  Scenario: install, attempt to reinstall, upgrade and uninstall an app that is available in the market-place # /home/phil/git/owncloud/core/apps-external/market/tests/acceptance/features/cliMain/marketInstallUpgradeUninstall.feature:9
    When the administrator invokes occ command "market:install activity"                                      # OccContext::theAdministratorInvokesOccCommand()
    Then the command should have been successful                                                              # OccContext::theCommandShouldHaveBeenSuccessful()
      The command was not successful, exit code was 1.
      stdOut was: 'activity: Installing new app ...
      activity: Archives of type application/x-empty are not supported
      '
      stdErr was: ''
       (Exception)

So the acceptance tests do cover that problem.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[phil-davis]

https://drone.owncloud.com/owncloud/market/3215/10/10

7 scenarios (7 passed)

[phil-davis]

@IljaN the acceptance tests will access the live market-place server when they run for about 3 minutes. That will happen nightly, and whenever someone (or dependabot) makes a PR to this app repo.

I guess that the market-place server gets thousands of requests every day anyway, so the performance difference due to this extra access will not be noticeable.

Does that seem OK to you, and whoever else manages that production server?