market:install is failing in CI

[phil-davis]

Example: https://drone.owncloud.com/owncloud/user_ldap/4001/69/16

+ cd /var/www/owncloud/federated
+ php occ market:install user_ldap
user_ldap: Installing new app ...
 user_ldap: Archives of type inode/x-empty are not supported 

Part of core issue owncloud/core#39387

[phil-davis]

https://drone.owncloud.com/owncloud/user_ldap/3993/69/16

+ cd /var/www/owncloud/federated
+ php occ market:install user_ldap
user_ldap: Installing new app ...
user_ldap: App installed.

It passed on the morning of 2022-06-16.

And passed on 2022-06-17 https://drone.owncloud.com/owncloud/user_ldap/3994/69/16

The first nightly fail was the morning of 2022-06-18: https://drone.owncloud.com/owncloud/user_ldap/3995/69/16

+ cd /var/www/owncloud/federated
+ php occ market:install user_ldap
user_ldap: Installing new app ...
 user_ldap: Archives of type inode/x-empty are not supported 

[phil-davis]

The latest commit in user_ldap was 28 days ago: owncloud/user_ldap@4002bcf

So it is not a change in user_ldap.

[phil-davis]

Guzzle 7 PR owncloud/core#39368 was merged on 2022-06-17 so I guess that is the suspicious one that might have caused the problem.

[phil-davis]

Yes, that Guzzle 7 PR is the problem. Locally I can do:

$ php occ market:install user_ldap
user_ldap: Installing new app ...
 user_ldap: Archives of type application/x-empty are not supported 
$ git checkout 7d3dabfb18725402b0816d5c6f7eed715b21fe71
$ make
$ php occ upgrade
$ php occ market:install user_ldap
user_ldap: Installing new app ...
user_ldap: App installed.

And the same for other apps, for example activity

So the market:install command is broken in core master. I will investigate...

[phil-davis]

This should have been fixed by the merge of PR #817 - it works-for-me locally now.

The change to the market app code will end up in the owncloud-daily-master-qa tarball when it is rebuilt tonight. user_ldap CI should pass. If it does, then I will close this issue.

[phil-davis]

Fix by #817
Acceptance tests added in #1030 so that we will automagically notice if some problem like this happens again.