Skip to content
This repository has been archived by the owner on Jun 19, 2023. It is now read-only.

Fix duplicate accounts #976

Merged
merged 3 commits into from
Dec 20, 2017
Merged

Fix duplicate accounts #976

merged 3 commits into from
Dec 20, 2017

Conversation

nasli
Copy link
Contributor

@nasli nasli commented Dec 14, 2017

Related issue in #923

This was referenced Dec 14, 2017
Closed
Merged
@nasli nasli requested a review from pablocarmu December 14, 2017 13:42
@nasli nasli added this to the 3.7.0 milestone Dec 14, 2017
@jesmrec
Copy link
Contributor

jesmrec commented Dec 14, 2017 •
edited
Loading

After checking this branch:

@nasli

@nasli
Copy link
Contributor Author

nasli commented Dec 15, 2017

Please @jesmrec review test 4 again, should be fixed, thanks!
For the test 3 we are going to handle in different issue since it is already in release branch

@jesmrec
Copy link
Contributor

jesmrec commented Dec 15, 2017 •
edited
Loading

@nasli

@nasli nasli force-pushed the fix_duplicate_accounts branch from 10fc7c9 to ff4b3f9 Compare December 18, 2017 14:41
@nasli
Copy link
Contributor Author

nasli commented Dec 18, 2017

Please review again latest bugs

@jesmrec
Copy link
Contributor

jesmrec commented Dec 19, 2017

Updated first message with new review

@nasli nasli merged commit 51114f0 into release_3.7.0 Dec 20, 2017
@nasli nasli deleted the fix_duplicate_accounts branch December 20, 2017 08:24
@nasli nasli mentioned this pull request Jan 16, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pablocarmu pablocarmu pablocarmu approved these changes

Assignees
No one assigned
Labels
approved by QA
Projects
None yet
Milestone
3.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@nasli @jesmrec @pablocarmu