Skip to content
This repository has been archived by the owner on Jun 19, 2023. It is now read-only.

[3.7.0] Release new version #923

Closed
33 tasks done
jesmrec opened this issue Jul 20, 2017 · 24 comments
Closed
33 tasks done

[3.7.0] Release new version #923

jesmrec opened this issue Jul 20, 2017 · 24 comments
Milestone

Comments

@jesmrec
Copy link
Contributor

jesmrec commented Jul 20, 2017

#Release a new version

TASKS:

  • [GIT] Create branch release_3.7.0 (freeze the code)
  • [GIT] Create branch library release_2.2.0_library (freeze the code)
  • [DEV] Remove private link icon in share view, Wait for Add oc:privatelink PROPFIND property for files on old and new dav endpoints core#28984 for a proper implementation
  • [DIS] Update changelog ios app
  • [DEV] Update version number
  • [DEV] Update readme number version app and library, xcode version
  • [DEV] Update third party file
  • [DEV] Get latest translations from master
  • [QA] Design Test plan @jesmrec
  • [QA] Regression Test @jesmrec
  • [DIS] Update screenshots.
  • [DIS] Create itunes new version
  • [DIS] Upload new ipa to appstore
  • [GIT] Merge branch release
  • [GIT] Merge branch library release
  • [GIT] Create tag and sign it
  • Ping to publish in social media

PR: #958
PR library: owncloud/ios-library#168


BUGS

@jesmrec jesmrec added this to the 3.7.0 milestone Jul 20, 2017
@nasli
Copy link
Contributor

nasli commented Sep 13, 2017

BUG (1)

Steps to reproduce

  1. create public link on 8.2.x server
  2. use "copy to clipboard" feature

Expected behaviour

iOS app shouldn't crash, even with older owncloud version

Actual behaviour

iOS app 3.5.6 crashes always

Server configuration

ownCloud version: (see ownCloud admin page)
8.2.x

Client

iOS version:
iOS 9.3.5

ownCloud app version:
3.6.2

Device model:
iPad 2

@jesmrec
Copy link
Contributor Author

jesmrec commented Nov 13, 2017

BUG (3) (low) [FIXED]

Steps to reproduce

  1. Create an account in OAuth2 server
  2. Go to settings view and select "Create new account"
  3. Input the same credentials of the account in 1.

Current behaviour

Error message is displayed correctly and webview shows "Authorization" button, skipping credentials.

Expected behaviour

Error message is displayed correctly and webview shows fields to input credentials

iPhone6Plus v10. Server10.0.4

@jesmrec
Copy link
Contributor Author

jesmrec commented Nov 13, 2017

BUG (4) (low) [FIXED]

Steps to reproduce

  1. Create an account in OAuth2 server
  2. Go to settings view and select "Edit credentials"

Current behaviour

Webview shows "Authorization" button, skipping credentials.

Expected behaviour

Webview shows fields to input credentials before authorizating

iPhone6Plus v10. Server10.0.4

NOTE: only happens if the server was not changed. If it was, credentials are requested correctly.

@jesmrec
Copy link
Contributor Author

jesmrec commented Nov 15, 2017

BUG (6) (medium) [FIXED]

Steps to reproduce

  1. install the app from scratch with a server 10, for example 10.0.3
  2. Enter credentials (no matter auth method) -> Login View
  3. Try to share by link a file or folder-> all info is correct displayed (link name, password, expiration...)
  4. Kill the app and open it again
  5. Try to share by link a file or folder

Current behaviour

Field "Link Name" does not appear. Field "Show file listing" (for folders) does not appear

Expected behaviour

All fields appear, so the server is version 10 or newer, where these fields were introduced (in the case of show file listing, was introduced in 10.0.1)

iPad Air v10.3. Server10.0.3 (SAML/OAuth2/basic)

It was checked the responsed JSON of the capabilities request when the app is opened for the steps 2. and 5. Both were the same:

{
    "ocs": {
        "data": {
            "capabilities": {
                "checksums": {
                    "preferredUploadType": "SHA1", 
                    "supportedTypes": [
                        "SHA1"
                    ]
                }, 
                "core": {
                    "pollinterval": 60, 
                    "status": {
                        "edition": "Enterprise", 
                        "installed": true, 
                        "maintenance": false, 
                        "needsDbUpgrade": false, 
                        "productname": "ownCloud", 
                        "version": "10.0.3.3", 
                        "versionstring": "10.0.3"
                    }, 
                    "webdav-root": "remote.php/webdav"
                }, 
                "dav": {
                    "chunking": "1.0"
                }, 
                "files": {
                    "bigfilechunking": true, 
                    "blacklisted_files": [
                        ".htaccess"
                    ], 
                    "privateLinks": true, 
                    "undelete": true, 
                    "versioning": true
                }, 
                "files_sharing": {
                    "api_enabled": true, 
                   "default_permissions": 31, 
                    "federation": {
                        "incoming": true, 
                        "outgoing": true
                    }, 
                    "group_sharing": true, 
                    "public": {
                        "enabled": true, 
                        "expire_date": {
                            "enabled": false
                        }, 
                        "multiple": true, 
                        "password": {
                            "enforced": false
                        }, 
                        "send_mail": false, 
                        "social_share": true, 
                        "supports_upload_only": true, 
                        "upload": true
                    }, 
                    "resharing": true, 
                    "share_with_group_members_only": true, 
                    "share_with_membership_groups_only": true, 
                    "user": {
                        "send_mail": false
                    }, 
                    "user_enumeration": {
                        "enabled": true, 
                        "group_members_only": false
                    }
                }, 
                "notifications": {
                    "ocs-endpoints": [
                        "list", 
                        "get", 
                        "delete"
                    ]
                }
            }, 
            "version": {
                "edition": "Enterprise", 
                "major": 10, 
                "micro": 3, 
                "minor": 0, 
                "string": "10.0.3"
            }
        }, 
        "meta": {
            "itemsperpage": "", 
            "message": "OK", 
            "status": "ok", 
            "statuscode": 100, 
            "totalitems": ""
        }
    }
}

@jesmrec
Copy link
Contributor Author

jesmrec commented Nov 16, 2017

BUG (7) (medium) [FIXED]

Steps to reproduce

  1. Login with SAML account
  2. Set a file (not a folder) as available offline.
  3. Wait until session expires (or force it)
  4. Input credentials

Current behaviour

Webview does not disappear and seems to be stucked. By killing it and open the app again, the session has started.

Expected behaviour

Webview disappears after inputing correct credentials.

iPadMini v10.1.1. Server10.0.4

@jesmrec
Copy link
Contributor Author

jesmrec commented Nov 16, 2017

BUG (8)

Steps to reproduce

  1. Share any content with another user (no matter if file or folder, no matter auth type)
  2. Open privileges view of this share and try to modify any of the privileges

Current behaviour

Wrong or no update parameter given

The request PUT to change the permissions includes the header

Content-Type: application/x-www-form-urlencoded

but the body of the request (the form itself) is empty

Expected behaviour

Privileges changed correctly

iPadMini v10.1.1. Server10.0.4
iPhone v10.0.1

@nasli
Copy link
Contributor

nasli commented Nov 16, 2017

@jesmrec please review (5) #956

@nasli nasli mentioned this issue Nov 16, 2017
@jesmrec
Copy link
Contributor Author

jesmrec commented Nov 17, 2017

BUG (10)

Steps to reproduce

  1. Install from scratch
  2. Open a new OAuth2 session
  3. Wait until token expires
  4. Perform more actions

Current behaviour

Token is not renewed. By killing the app and open it again, the token expires and from this moment, token expires correctly

Expected behaviour

Correct expirations from the beginning.

iPadMini v10.1.1. Server10.0.4
iPhone v10.0.1

@jesmrec
Copy link
Contributor Author

jesmrec commented Nov 21, 2017

IMPRVMT (11) [FIXED]

Some wording issues in login view:

Secure Connection Established -> Secure Connection
Connection Established -> Non-secure connection

to avoid a discrepance between the word Connection and the button label Connect

@nasli
Copy link
Contributor

nasli commented Nov 21, 2017

@jesmrec New fix for handling cookies #962,

@davigonz davigonz reopened this Nov 22, 2017
@nasli nasli mentioned this issue Nov 22, 2017
3 tasks
@jesmrec
Copy link
Contributor Author

jesmrec commented Nov 23, 2017

@nasli about (4): the first time after installing that you try to edit credentials, credentials are not asked. After that, credentials are always asked.

Now it is a low sev bug.

@nasli
Copy link
Contributor

nasli commented Nov 27, 2017

Bug (8)#923 (comment) related sharees, ready to test in release_3.7.0 branch @jesmrec

@nasli
Copy link
Contributor

nasli commented Nov 28, 2017

Bug (10) #923 (comment) Related OAuth session expired, forcing directly from the database makes the cookies does not expire, and with the fix from cookies now when you open the app, we keep using same cookies, so session never expire.
Try with a lower timing expiration and remove session from server settings UI.

Could be an issue in OAuth, if you remove from OAuth settings the sessions, the cookies keep alive..

@jesmrec
Copy link
Contributor Author

jesmrec commented Nov 28, 2017

BUG (12)

Steps to reproduce

  1. Install from scratch
  2. Open a new SAML session
  3. Wait until expires (or force it)
  4. Input credentials again and perform any action

Current behaviour

Login view is raised again

Expected behaviour

Session starts and usen can perform as many actions as he wants

iPadMini iOS10.1.1. Server10.0.3
iPhone iOS9 Server10.0.3

@nasli
Copy link
Contributor

nasli commented Nov 29, 2017

Bug (12) seems to be the same as (7), looking it

@nasli
Copy link
Contributor

nasli commented Dec 11, 2017

Bug (12) fixed within #970, (7) will be handle in different issue

@nasli
Copy link
Contributor

nasli commented Dec 12, 2017

Bug (7) ready to test @jesmrec PR: #974

@nasli
Copy link
Contributor

nasli commented Dec 14, 2017

Please @jesmrec take a look at this pr #976 to check issue with duplicate accounts, thanks!

@ChrisEdS
Copy link
Contributor

ChrisEdS commented Dec 18, 2017

BUG (14)

[iOS11] No sharing windows present
also reported here: #980

Steps to reproduce

  1. Open ownCloud-App in iOS11
  2. Go to a file (PDF as example)
  3. Try to open the file in another app

Expected behaviour

The "sharing-window" appears

Actual behaviour

Nothing appears

Same when you swipe right on a file and try to "open with"

iOS version: 11.1.2

@jesmrec
Copy link
Contributor Author

jesmrec commented Dec 18, 2017

About BUG (14), the problem only happens when the app is installed from scratch and can be avoided when the app is opened after killing or after background (Could you check @ChrisEdS ?) as workaround.

@ChrisEdS
Copy link
Contributor

You're right, Jesus. After a quit and restart it works. Exactly once. Either with swipe or over the button. Unfortunately, this workaround does not work for the my wrapped MDM version.

@ChrisEdS
Copy link
Contributor

It sounds crazy but I think the menu is there but invisible. After the "Open With" order, the app does not respond exactly to the area where the menu would normally be. If I press on an area that would not be covered by the menu (the menu will disappear normally), everything will react again.

In summary, I believe that the menu is already there - but "invisible". Maybe that helps with troubleshooting.

@nasli
Copy link
Contributor

nasli commented Dec 20, 2017

Bug (14) could be related with a changes in permissions in iOS 11, the app bundle url we share, maybe we need to use a temporal folder to share it.

@jesmrec
Copy link
Contributor Author

jesmrec commented Dec 21, 2017

At this point all the bugs are fixed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants