Update Sabre-DAV to 1.8.9 #6723

DeepDiver1975 · 2014-01-10T21:11:29Z

🚧

FYI: we will move to Sabre-DAV 1.9.x within the next 2 months due to https://github.com/fruux/sabre-dav/pull/398 which finally moved the depth infinity support upstream.

Conflicts: lib/private/connector/sabre/file.php

DeepDiver1975 · 2014-01-10T23:16:08Z

@georgehrke @tanghus we need to talk about upgrading Sabre in contacts and calendar 😉

@karlitschek @bantu @icewind1991

bantu · 2014-01-10T23:17:41Z

apps/files_sharing/lib/api.php

@@ -299,6 +299,7 @@ public static function updateShare($params) {
 				return self::updatePublicUpload($share, $params);
 			}
 		} catch (\Exception $e) {
+


In case this wasn't clear: Remove the pointless change from the diff?

bantu · 2014-01-10T23:25:57Z

Patch is mostly switching to namespacing and looks good to me. Didn't test.

icewind1991 · 2014-01-11T12:29:10Z

Litmus succeeds with above fix.

ghost · 2014-01-11T12:52:09Z

Test passed.
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/2558/

karlitschek · 2014-01-11T15:16:44Z

Has someone done some real life tests with Mirall, the mobiel apps and caldav/carddav clients?

georgehrke · 2014-01-11T15:17:28Z

I'll test the calendar tomorrow

DeepDiver1975 · 2014-01-22T20:58:22Z

@karlitschek @tanghus @georgehrke

We have to think about how to decouple core, sabre, calendar and contacts (and probably other apps reusing SabreDAV ???) - we have always been talking about:

apps have to be self-contained
apps are not allowed to have dependencies to other apps
apps should only interact/depend with/on the public core api

As a result I suggest to:

keep it as it is (as a result calendar and contacts have to shipped with core forever and violate the architectural principal of ownCloud)
Calendar, Contacts and others ship their own version of SabreDAV independently
We move CalDAV and CardDAV into core and offer a public API to register calendars and adressbooks (Unify WebDav, CalDAV and CardDav entrypoints #5939, Combine cal- and carddav endpoint #4951)

karlitschek · 2014-01-22T21:14:19Z

Come on. This sounds like looking for a technical solution for a human problem. SabreDAV is used for CalDAV, CardAV and WebDAV and nothing more.
This problem can easily solved if the person who updates SabreDAV tests all three cases as I have asked for before.
That is all that is needed and that is actually very doable and not a lot fo work.

DeepDiver1975 · 2014-01-22T21:22:04Z

SabreDAV is used for CalDAV, CardAV and WebDAV and nothing more.

100% sure?

tanghus · 2014-01-22T21:27:24Z

I assume the three latter bullet point are alternative options?

Proper testing solves some of the issues, but not e.g. #4951 and the hack I had to make in calendar to get the much requested CalDAV birthday calendar.

DeepDiver1975 · 2014-01-22T21:28:59Z

I assume the three latter bullet point are alternative options?

Indeed - I was not clear on that - thx

Conflicts: 3rdparty

DeepDiver1975 · 2014-01-27T12:40:42Z

depends on owncloud-archive/3rdparty#70

ghost · 2014-01-27T14:16:28Z

Test failed.
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/2788/

tanghus · 2014-03-09T23:07:14Z

we will move to Sabre-DAV 1.9.x within the next 2 months

Wow, has it already been two months? Maybe we should continue the discussion ;)

icewind1991 · 2014-03-10T11:43:47Z

Well, 1.9.x doesn't seem to be released yet, upgrading to 1.8.9 is probably something we should do though.

DeepDiver1975 · 2014-03-10T12:23:28Z

@evert What are your plans regarding release of 1.9.x? THX

evert · 2014-03-11T01:26:08Z

We're not quite there yet unfortunately :( caldav scheduling is the major blocker and it's taken a lot of time to get that through.

DeepDiver1975 · 2014-04-07T17:36:31Z

@evert almost another month did pass by - any news on the release of 1.9.x?

PVince81 · 2014-04-08T09:43:17Z

Please rebase

Conflicts: 3rdparty apps/files/appinfo/remote.php lib/private/connector/sabre/aborteduploaddetectionplugin.php lib/private/connector/sabre/directory.php lib/private/connector/sabre/file.php lib/private/connector/sabre/node.php lib/private/connector/sabre/quotaplugin.php tests/lib/connector/sabre/file.php

DeepDiver1975 · 2014-04-08T11:32:53Z

Please rebase

rebased - now uses Sabre 1.8.9

ghost · 2014-04-08T11:38:47Z

💣 Test Failed. 💣
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/4132/

ghost · 2014-04-08T11:58:40Z

💣 Test Failed. 💣
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/4133/

ghost · 2014-04-08T12:39:52Z

💣 Test Failed. 💣
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/4135/

ghost · 2014-04-08T18:31:28Z

💣 Test Failed. 💣
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/4151/

Conflicts: apps/files/appinfo/remote.php lib/private/connector/sabre/node.php

ghost · 2014-04-15T20:38:45Z

💣 Test Failed. 💣
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/4293/

Conflicts: apps/files_encryption/tests/webdav.php lib/private/connector/sabre/aborteduploaddetectionplugin.php lib/private/connector/sabre/directory.php lib/private/connector/sabre/file.php lib/private/connector/sabre/node.php lib/private/connector/sabre/objecttree.php lib/private/connector/sabre/quotaplugin.php tests/lib/connector/sabre/aborteduploaddetectionplugin.php tests/lib/connector/sabre/file.php tests/lib/connector/sabre/quotaplugin.php

ghost · 2014-04-28T20:59:36Z

💣 Test Failed. 💣
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/4494/

scrutinizer-notifier · 2014-04-28T21:02:24Z

The inspection completed: 13 new issues

ghost · 2014-04-28T21:17:38Z

💣 Test Failed. 💣
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/4495/

ghost · 2014-04-28T22:51:03Z

💣 Test Failed. 💣
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/4496/

phsc84 · 2014-05-16T04:45:05Z

Sabre 2.0.0-beta1 is out!
https://github.com/fruux/sabre-dav/releases/tag/2.0.0beta1

phsc84 · 2014-05-16T04:59:06Z

#2146

DeepDiver1975 · 2014-05-19T12:55:12Z

I'm closing this for now - we have to migrate to SabreDAV 2.0 after OC7

icewind1991 · 2014-05-19T14:54:26Z

Note that sabre/dav 2.0 requires php 5.4

evert · 2014-05-19T20:17:01Z

Wouldn't you want to keep the changes in this pull request? All the changes still apply.

DeepDiver1975 · 2014-05-20T05:32:11Z

@icewind1991 oh - grrrrrrr aaaaaarrgghhhhh

thx for the info

DeepDiver1975 added 5 commits January 9, 2014 14:25

Upgrade SabreDAV to 1.8.7

fc90171

Updating SabreDAV namespaces

06874e3

Merge branch 'master' into update-sabre-2.0

48a057d

Conflicts: lib/private/connector/sabre/file.php

Remove double backslash

2a19d98

Remove double backslash

8deea8c

bantu reviewed Jan 10, 2014
View reviewed changes

Fix Sabredav namespaces in webdav's remote.php

14366ac

Merge branch 'master' into update-sabre-2.0

862cbdf

Conflicts: 3rdparty

DeepDiver1975 mentioned this pull request Jan 27, 2014

Upgrade SabreDAV to 1.8.7 owncloud-archive/3rdparty#70

Closed

DeepDiver1975 mentioned this pull request Apr 8, 2014

Convert timestamp to int before calling Sabre_DAV_Property_GetLastModified #8098

Merged

DeepDiver1975 changed the title ~~Update Sabre-DAV to 1.8.7~~ Update Sabre-DAV to 1.8.9 Apr 8, 2014

fixing Sabre class names

1bf5291

fix unit test

6ad0cd7

Merge branch 'master' into update-sabre-2.0

5a8a699

Merge branch 'master' into update-sabre-2.0

a8fc5ae

Conflicts: apps/files/appinfo/remote.php lib/private/connector/sabre/node.php

DeepDiver1975 added 2 commits April 28, 2014 21:49

Update 3rdparty

e4ea104

Merge branch 'master' into update-sabre-2.0

5dfd694

DeepDiver1975 closed this May 19, 2014

DeepDiver1975 deleted the update-sabre-2.0 branch May 19, 2014 12:55

DeepDiver1975 restored the update-sabre-2.0 branch May 20, 2014 05:30

lock bot locked as resolved and limited conversation to collaborators Aug 27, 2019

Update Sabre-DAV to 1.8.9 #6723

Update Sabre-DAV to 1.8.9 #6723

Conversation

DeepDiver1975 commented Jan 10, 2014

DeepDiver1975 commented Jan 10, 2014

bantu Jan 10, 2014

Choose a reason for hiding this comment

DeepDiver1975 Jan 11, 2014

Choose a reason for hiding this comment

bantu Jan 12, 2014

Choose a reason for hiding this comment

bantu commented Jan 10, 2014

icewind1991 commented Jan 11, 2014

ghost commented Jan 11, 2014

karlitschek commented Jan 11, 2014

georgehrke commented Jan 11, 2014

DeepDiver1975 commented Jan 22, 2014

karlitschek commented Jan 22, 2014

DeepDiver1975 commented Jan 22, 2014

tanghus commented Jan 22, 2014

DeepDiver1975 commented Jan 22, 2014

DeepDiver1975 commented Jan 27, 2014

ghost commented Jan 27, 2014

tanghus commented Mar 9, 2014

icewind1991 commented Mar 10, 2014

DeepDiver1975 commented Mar 10, 2014

evert commented Mar 11, 2014

DeepDiver1975 commented Apr 7, 2014

PVince81 commented Apr 8, 2014

DeepDiver1975 commented Apr 8, 2014

ghost commented Apr 8, 2014

ghost commented Apr 8, 2014

ghost commented Apr 8, 2014

ghost commented Apr 8, 2014

ghost commented Apr 15, 2014

ghost commented Apr 28, 2014

scrutinizer-notifier commented Apr 28, 2014

ghost commented Apr 28, 2014

ghost commented Apr 28, 2014

phsc84 commented May 16, 2014

phsc84 commented May 16, 2014

DeepDiver1975 commented May 19, 2014

icewind1991 commented May 19, 2014

evert commented May 19, 2014

DeepDiver1975 commented May 20, 2014