Combine cal- and carddav endpoint

[evert]

Hey guys,

I am at CalConnect, which is the tri-yearly meetup for the internet calendaring standards organization. We do testing between a bunch of different vendors, and as I'm representing sabredav, I also get questions about owncloud.

One of the things that was mentioned was the fact that owncloud exposes 2 separate endpoints for cal- and carddav. Specifically for some clients that support both these protocols, it can be a bit confusing as there are also 2 principal urls.

I think it would be good to combine both endpoints into one. I imagine it should be relatively easy, as you just need to make sure that calendars and addressbooks are in both trees, and all plugins are loaded for both endpoints.

That way you also don't have to break the existing urls.

I feel this is a better design, and will provide better compatibility as clients get more advanced.

// cc @tanghus

[tanghus]

Could we combine the two loaders[1] and use the same Sabre_DAV_Server to conditionally add Cal-/CardDAV plugins based on what is enabled?
Also I had to make a validator plugin which runs before create/write for clients that don't add a proper UID [2]. Would that run for both Cal- and CardDAV?

[1]
https://github.com/owncloud/contacts/blob/master/appinfo/remote.php
https://github.com/owncloud/calendar/blob/master/appinfo/remote.php
[2] https://github.com/owncloud/contacts/blob/master/lib/carddav/validatorplugin.php

[evert]

Yes you totally can load or not load plugins depending on your settings. And you can also leave stuff out the tree, so I don't think there's a step backward in any case..

As for the validator plugin, you could indeed re-use it, but:

1. The UID is almost always there in iCalendar objects anyway
2. The UID is a property of the VEVENT, not the top-level VCALENDAR, so make sure you add specific behavior for whether something is a calendarobject or a card :)

[tanghus]

Great. I've set the milestone to ownCloud 7 as we don't want to break anything now ;)

[Niduroki]

Superseeded by #5939