-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests-only] Refactored step implementation for adding public link to server #40451
Conversation
Kudos, SonarCloud Quality Gate passed! |
27bad1b
to
ab5f752
Compare
ab5f752
to
ca2b581
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ca2b581
to
0e9aee6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
0e9aee6
to
b9e72e8
Compare
The PR is passed with full-ci (https://drone.owncloud.com/owncloud/core/37132) except for the PHP-unit test failure with the issue #40457. I have removed the tag full-ci to get CI green and this PR can be merged. |
b9e72e8
to
8da738c
Compare
Description
Refactored the step implementation for
When the public adds the public link to :server as user :username using the webUI
. The function now works with the same approach either the local or remote server when adding a public link to the server.Related Issue
How Has This Been Tested?
Types of changes
Checklist: