Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] Refactored step implementation for adding public link to server #40451

Merged
merged 1 commit into from
Nov 9, 2022

Conversation

grgprarup
Copy link
Contributor

@grgprarup grgprarup commented Oct 25, 2022

Description

Refactored the step implementation for When the public adds the public link to :server as user :username using the webUI. The function now works with the same approach either the local or remote server when adding a public link to the server.

$server = $this->featureContext->substituteInLineCodes($server);
$this->publicLinkFilesPage->addToServer($server);

Related Issue

How Has This Been Tested?

  • 🤖

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@grgprarup grgprarup force-pushed the add-step-implementation branch from 27bad1b to ab5f752 Compare October 28, 2022 06:05
@grgprarup grgprarup changed the title [tests-only] [full-ci] Added step implementation for adding public link to server [tests-only] [full-ci] Refactored step implementation for adding public link to server Oct 28, 2022
@grgprarup grgprarup force-pushed the add-step-implementation branch from ab5f752 to ca2b581 Compare October 28, 2022 06:51
@grgprarup grgprarup requested a review from saw-jan October 28, 2022 06:56
@grgprarup grgprarup marked this pull request as ready for review October 28, 2022 06:56
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grgprarup grgprarup force-pushed the add-step-implementation branch from ca2b581 to 0e9aee6 Compare October 31, 2022 03:55
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@grgprarup grgprarup changed the title [tests-only] [full-ci] Refactored step implementation for adding public link to server [tests-only] Refactored step implementation for adding public link to server Nov 7, 2022
@grgprarup grgprarup force-pushed the add-step-implementation branch from 0e9aee6 to b9e72e8 Compare November 7, 2022 10:10
@grgprarup
Copy link
Contributor Author

The PR is passed with full-ci (https://drone.owncloud.com/owncloud/core/37132) except for the PHP-unit test failure with the issue #40457. I have removed the tag full-ci to get CI green and this PR can be merged.

@grgprarup grgprarup force-pushed the add-step-implementation branch from b9e72e8 to 8da738c Compare November 7, 2022 10:36
@individual-it individual-it merged commit 353925d into master Nov 9, 2022
@delete-merged-branch delete-merged-branch bot deleted the add-step-implementation branch November 9, 2022 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants