Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] [full-ci] add webUI tests to add owncloud server for a public link share #1145

Merged
merged 1 commit into from
Nov 9, 2022
Merged

[tests-only] [full-ci] add webUI tests to add owncloud server for a public link share #1145

merged 1 commit into from
Nov 9, 2022

Conversation

grgprarup
Copy link
Contributor

@grgprarup grgprarup commented Oct 25, 2022 •
edited
Loading

Description

Added a scenario to describe the activity generation when adding a server on a public link share.

Related

@ownclouders
Copy link
Contributor

ownclouders commented Oct 25, 2022 •
edited
Loading

💥 Acceptance tests pipeline webUISharingExt-Test-firefox-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/activity/3025/23

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiActivity-master-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/activity/2985/24

This was referenced Oct 25, 2022
Merged
Closed
@grgprarup grgprarup self-assigned this Oct 25, 2022
@grgprarup grgprarup marked this pull request as ready for review October 28, 2022 06:58
kiranparajuli589
kiranparajuli589 reviewed Oct 28, 2022
View reviewed changes
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

saw-jan
saw-jan reviewed Oct 28, 2022
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SagarGi
SagarGi reviewed Nov 3, 2022
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

SwikritiT
SwikritiT reviewed Nov 3, 2022
View reviewed changes
Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@SwikritiT SwikritiT requested review from individual-it and removed request for individual-it November 3, 2022 04:02
individual-it
individual-it requested changes Nov 4, 2022
View reviewed changes
Copy link
Member

@individual-it individual-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally looks good, but the test does not pass

WebUISharingContext::thePublicAddsThePublicLinkToUsingTheWebUI()

      Page\FilesPageBasic::waitTillPageIsLoaded timeout waiting for page to load (Exception)

@grgprarup
Copy link
Contributor Author

generally looks good, but the test does not pass

WebUISharingContext::thePublicAddsThePublicLinkToUsingTheWebUI()

      Page\FilesPageBasic::waitTillPageIsLoaded timeout waiting for page to load (Exception)

There is PR owncloud/core#40451 that refactors this step, so need to merge that. I have added a new commit in this PR to check against that changes in core.

@grgprarup grgprarup changed the title [tests-only] add webUI tests to add owncloud server for a public link share [tests-only] [full-ci] add webUI tests to add owncloud server for a public link share Nov 7, 2022
@individual-it
Copy link
Member

#40451 is merged

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@individual-it individual-it merged commit 5ba9c65 into master Nov 9, 2022
@delete-merged-branch delete-merged-branch bot deleted the add-webui-test branch November 9, 2022 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiranparajuli589 kiranparajuli589 kiranparajuli589 left review comments

@SwikritiT SwikritiT SwikritiT left review comments

@SagarGi SagarGi SagarGi left review comments

@saw-jan saw-jan saw-jan left review comments

@individual-it individual-it individual-it approved these changes

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

Assignees

@grgprarup grgprarup

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@grgprarup @ownclouders @individual-it @kiranparajuli589 @SwikritiT @SagarGi @saw-jan