Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use html body for message sent via email for password change #35260

Merged
merged 1 commit into from
May 17, 2019

Conversation

sharidas
Copy link
Contributor

Description

The message sent via email for password success to the user should be sent in html instead of plain text. This change addresses the issue.

Related Issue

Motivation and Context

The message sent via email for password success to the user should be sent in html instead of plain text. This change addresses the issue.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

…assword change

Use html body for message sent via email
for password change.

Signed-off-by: Sujith H <sharidasan@owncloud.com>
@sharidas sharidas changed the base branch from master to stable10 May 17, 2019 12:32
@sharidas sharidas self-assigned this May 17, 2019
@sharidas sharidas requested review from micbar and PVince81 May 17, 2019 12:32
@sharidas sharidas modified the milestones: QA, development May 17, 2019
@sharidas
Copy link
Contributor Author

Original PR owncloud-archive/user_management#181

@sharidas sharidas changed the title Html body for message stable10 Use html body for message sent via email for password change May 17, 2019
@codecov
Copy link

codecov bot commented May 17, 2019

Codecov Report

Merging #35260 into stable10 will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #35260      +/-   ##
==============================================
- Coverage       64.52%   64.52%   -0.01%     
  Complexity      20080    20080              
==============================================
  Files            1289     1289              
  Lines           76944    76946       +2     
  Branches         1299     1299              
==============================================
- Hits            49648    49647       -1     
- Misses          26915    26918       +3     
  Partials          381      381
Flag Coverage Δ Complexity Δ
#javascript 53.2% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.72% <100%> (-0.01%) 20080 <0> (ø)
Impacted Files Coverage Δ Complexity Δ
settings/Controller/UsersController.php 85.91% <100%> (+0.08%) 132 <0> (ø) ⬇️
apps/encryption/templates/settings-admin.php 78.94% <0%> (-5.27%) 0% <0%> (ø)
apps/encryption/lib/Session.php 98.03% <0%> (-1.97%) 22% <0%> (ø)
...eratedfilesharing/lib/Controller/OcmController.php 66.06% <0%> (-0.21%) 30% <0%> (ø)
lib/private/Server.php 86.56% <0%> (-0.12%) 253% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52953a8...961433c. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented May 17, 2019

Codecov Report

Merging #35260 into stable10 will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #35260      +/-   ##
==============================================
- Coverage       64.52%   64.52%   -0.01%     
  Complexity      20080    20080              
==============================================
  Files            1289     1289              
  Lines           76944    76946       +2     
  Branches         1299     1299              
==============================================
- Hits            49648    49647       -1     
- Misses          26915    26918       +3     
  Partials          381      381
Flag Coverage Δ Complexity Δ
#javascript 53.2% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.72% <100%> (-0.01%) 20080 <0> (ø)
Impacted Files Coverage Δ Complexity Δ
settings/Controller/UsersController.php 85.91% <100%> (+0.08%) 132 <0> (ø) ⬇️
apps/encryption/templates/settings-admin.php 78.94% <0%> (-5.27%) 0% <0%> (ø)
apps/encryption/lib/Session.php 98.03% <0%> (-1.97%) 22% <0%> (ø)
...eratedfilesharing/lib/Controller/OcmController.php 66.06% <0%> (-0.21%) 30% <0%> (ø)
lib/private/Server.php 86.56% <0%> (-0.12%) 253% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52953a8...961433c. Read the comment docs.

Copy link
Contributor

@micbar micbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@micbar micbar merged commit de832e7 into stable10 May 17, 2019
@delete-merged-branch delete-merged-branch bot deleted the html-body-for-message-stable10 branch May 17, 2019 13:34
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants