Skip to content
This repository has been archived by the owner on Dec 3, 2019. It is now read-only.

Use html body for message sent via email for password change #181

Merged
merged 1 commit into from
May 17, 2019

Conversation

sharidas
Copy link
Contributor

Use html body for message sent via email
for password change.

Signed-off-by: Sujith H sharidasan@owncloud.com

@sharidas sharidas requested review from PVince81 and micbar May 17, 2019 11:07
@sharidas sharidas self-assigned this May 17, 2019
@sharidas
Copy link
Contributor Author

sharidas commented May 17, 2019

Description

The message sent via email for password success to the user should be sent in html instead of plain text. This change addresses the issue.

Issue

How is it tested

  • Create an user with email id
  • Access the email to set the password for the user
  • Once the password is successful verify the email to see the password change. Here are the screenshots

HTML

Screenshot_2019-05-17 MailHog

Plain Text

Screenshot_2019-05-17 MailHog(1)

@sharidas sharidas force-pushed the html-body-for-message branch from bf04cb3 to 206c7a4 Compare May 17, 2019 11:38
@codecov
Copy link

codecov bot commented May 17, 2019

Codecov Report

Merging #181 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #181   +/-   ##
=========================================
  Coverage     78.73%   78.73%           
  Complexity      214      214           
=========================================
  Files            26       26           
  Lines           917      917           
=========================================
  Hits            722      722           
  Misses          195      195
Impacted Files Coverage Δ Complexity Δ
lib/Controller/UsersController.php 85.97% <100%> (ø) 134 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d52e1fc...206c7a4. Read the comment docs.

@codecov
Copy link

codecov bot commented May 17, 2019

Codecov Report

Merging #181 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #181      +/-   ##
===========================================
+ Coverage     78.73%   78.8%   +0.06%     
  Complexity      214     214              
===========================================
  Files            26      26              
  Lines           917     920       +3     
===========================================
+ Hits            722     725       +3     
  Misses          195     195
Impacted Files Coverage Δ Complexity Δ
lib/Controller/UsersController.php 86.05% <100%> (+0.08%) 134 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d52e1fc...369947c. Read the comment docs.

@sharidas sharidas force-pushed the html-body-for-message branch from 206c7a4 to d69ca66 Compare May 17, 2019 11:48
@micbar
Copy link
Contributor

micbar commented May 17, 2019

LGTM now.
Lets wait for drone.

Use html body for message sent via email
for password change.

Signed-off-by: Sujith H <sharidasan@owncloud.com>
@sharidas
Copy link
Contributor Author

Backport PR owncloud/core#35260

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants