Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed personal note in link share email #30789

Merged
merged 1 commit into from
Mar 19, 2018

Conversation

PVince81
Copy link
Contributor

Description

Related Issue

For #29696 (comment)

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Mar 15, 2018

Codecov Report

Merging #30789 into master will increase coverage by <.01%.
The diff coverage is 55.55%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #30789      +/-   ##
============================================
+ Coverage     61.97%   61.97%   +<.01%     
- Complexity    18352    18357       +5     
============================================
  Files          1157     1157              
  Lines         69051    69065      +14     
  Branches       1242     1242              
============================================
+ Hits          42794    42804      +10     
- Misses        25885    25889       +4     
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 52.33% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 63.06% <55.55%> (ø) 18357 <8> (+5) ⬆️
Impacted Files Coverage Δ Complexity Δ
...b/private/Share/Filters/MailNotificationFilter.php 86.66% <0%> (-13.34%) 6 <1> (+1)
core/ajax/share.php 0% <0%> (ø) 0 <0> (ø) ⬇️
core/templates/mail.php 80% <100%> (+8.57%) 0 <0> (ø) ⬇️
core/templates/altmail.php 75% <100%> (+15%) 0 <0> (ø) ⬇️
lib/private/Share/MailNotifications.php 90.09% <100%> (+0.4%) 28 <7> (+4) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6321cf8...d63ac46. Read the comment docs.

This instead of replacing the whole body
@PVince81 PVince81 force-pushed the share-link-email-embedded-note branch from 3bc4c01 to d63ac46 Compare March 15, 2018 15:15
@PVince81 PVince81 requested a review from DeepDiver1975 March 15, 2018 15:18
@PVince81
Copy link
Contributor Author

did my best with coverage... the share.php part is not coverable

@PVince81 PVince81 requested a review from jvillafanez March 19, 2018 09:52
@DeepDiver1975 DeepDiver1975 merged commit 420fd3d into master Mar 19, 2018
@DeepDiver1975 DeepDiver1975 deleted the share-link-email-embedded-note branch March 19, 2018 11:02
@PVince81
Copy link
Contributor Author

stable10: #30813

@lock
Copy link

lock bot commented Jul 31, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants