Public links: Add personal note and option to receive a copy

[pmaier1]

Add a message field to provide a personal note in the mail notification

As a user I want to add a personal note when sharing with externals via public link to reference a previous conversations or just provide some hints to externals that never used ownCloud before.

The mail notification should be just like the default, but inserting a paragraph with my personal note after the introduction text.

Add a checkbox "Receive a copy" to set yourself in CC of the mail notification

As a user I want to be able to receive a copy (put me on CC) of the mail notifications I send out when sharing public links for that I can see what the recipients see and to be able to use that mail notification afterwards in my mail client (forward to others, reference the notification, etc.).

A mockup would be great!

@felixheidecke @PVince81

[felixheidecke]

We could have a separate section below. The Textarea expands on putting text in as in this example:

[pmaier1]

Yes, looks nice! Maybe we can make it expandable/collapsible to save some space. Recipient field requirements are here #29695.

What about backend for inserting the message to the mail notification and the optional CC? Is this something easy? @PVince81

[pmaier1]

Lol, just saw the German translation for "File Drop" in the mockup. This is bad and should be called "File Drop" as well. Can we make this a non-translatable string?

[felixheidecke]

Can we make this a non-translatable string?

Sure can :-D

[felixheidecke]

As I recall, there is a greater rework of the sharing due. Can we postpone changes until then?

[PVince81]

It might be possible to use the given message when sending emails, but the custom message will not be saved anywhere.

[PVince81]

custom message as displayed in UI must use some template as preset

[pmaier1]

It might be possible to use the given message when sending emails, but the custom message will not be saved anywhere.

I don't think it needs to be saved somewhere. Audit log entries might be demanded, though.

As I recall, there is a greater rework of the sharing due. Can we postpone changes until then?

This is not that much related to the other stuff except that we want to come away from the modal and integrate in the sharing sidebar.

Just thinking loud: When tackling this maybe we could enable editing the whole template to cover other use cases where people are unhappy with the templates as well. Generally inserting a note to the template would be preferable though, IMO. Editing templates should happen in the template editor.

[PVince81]

@felixheidecke please ping @jvillafanez for backend work when needed

[PVince81]

• public API + exposing email template: Expose link share email template through APIs #29937

[PVince81]

maybe at first we just go with sending whatever message is there without the public API as the latter might be more tricky as it seems to violate some semantics

[felixheidecke]

Has been addressed in #29935

[pmaier1]

Some further feedback:

• The flow is fine as it is. No need to be able to edit the whole template. We should stay with injecting the personal note. ✔️
• Currently the personal note does not respect custom mail templates. Instead it overrides and injects the message in the default template. This needs to be addressed ❌

[pmaier1]

I assume that the functionality is currently not available via API, right? We should schedule this for a later iteration to make it available in the clients as well at some point. @PVince81

[PVince81]

@pmaier1 the current code should use the custom mail template only if no personal note is given, else override it fully with whatever is written in the personal note.

Are you saying that it should use the custom mail template internally and inject the personal note in the middle of it ?

[pmaier1]

Are you saying that it should use the custom mail template internally and inject the personal note in the middle of it ?

Yes, I think that this is the expectation.

[PVince81]

Ok, assigning self, need to modify the backend

[PVince81]

@pmaier1 the email template doesn't have space for a personal note: https://github.com/owncloud/core/blob/master/core/templates/mail.php#L15

Considering that people might customize this file or already did so, they'd need to also adjust accordingly.

What we can do is add an additional variable containing the personal note in the default template, as an additional sentence.

For example if a personal note is set, then it could add a block: "Personal note from the sender: %s".

So it could look like this:

Hey there,

just letting you know that Vincent shared something with you.

Personal note from sender: hey Patrick, look at this thing!

View it!

[jvillafanez]

That template won't work for the email notifications neither. You might receive the update notification via email, and it's impossible to fit it in that template.
We need to figure out something more generic.

[PVince81]

@jvillafanez this mechanism will never be using the notifications app. This is because the email in question will always be sent to users who are outside of ownCloud. Our notifications app can only notify users who have accounts on ownCloud.

[PVince81]

PR here: #30789

Note that this adds an optional section in the email if personal note is set.
Any custom template will need manual adjustments accordingly.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.