Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable10] Revert "Highlight files after setFiles" #29019

Merged
merged 1 commit into from
Sep 15, 2017
Merged

[stable10] Revert "Highlight files after setFiles" #29019

merged 1 commit into from
Sep 15, 2017

Conversation

PVince81
Copy link
Contributor

Fixes #28106

See ticket for steps.

@PVince81 PVince81 added this to the QA milestone Sep 15, 2017
@PVince81 PVince81 self-assigned this Sep 15, 2017
@PVince81 PVince81 mentioned this pull request Sep 15, 2017
Closed
@PVince81
Copy link
Contributor Author

reverts #28665

@PVince81 PVince81 mentioned this pull request Sep 15, 2017
Merged
@SergioBertolinSG
Copy link
Contributor

Works 👍

@PVince81
Copy link
Contributor Author

JS tests passed on CI. Waiting for Travis UI tests though.

@PVince81 PVince81 mentioned this pull request Sep 15, 2017
Closed
31 tasks
@phil-davis
Copy link
Contributor

phil-davis commented Sep 15, 2017 •
edited
Loading

Note: Travis job https://travis-ci.org/owncloud/core/jobs/275851372 got:

     exception 'SensioLabs\Behat\PageObjectExtension\PageObject\Exception\UnexpectedPageException' with message 'Expected to be on "http://owncloud:8889/index.php/apps/files/" but found "http://owncloud:8889/index.php/login?redirect_url=%252Findex.php%252Fapps%252Ffiles%252F" instead' in /home/travis/build/owncloud/core/tests/ui/features/lib/FilesPage.php:166

is a "random" thing that happens sometimes (the SauceLabs video will show a sudden "CSRF Failed"), not related to this PR.

The job could be restarted, but it passed all other scenarios fine.

Update: all other Travis jobs have passed.
I restarted this job, just for fun, and since Jenkins has a while to go anyhow.
And it passed the 2nd time.

@PVince81 PVince81 merged commit 84c6927 into stable10 Sep 15, 2017
@PVince81 PVince81 deleted the stable10-filelist-scrollto-revert branch September 15, 2017 14:03
@lock
Copy link

lock bot commented Aug 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SergioBertolinSG SergioBertolinSG Awaiting requested review from SergioBertolinSG

@felixheidecke felixheidecke Awaiting requested review from felixheidecke

Assignees

@PVince81 PVince81

Labels
4 - To release status/STALE
Projects
None yet
Milestone
10.0.4
Development

Successfully merging this pull request may close these issues.
4 participants
@PVince81 @SergioBertolinSG @phil-davis @ownclouders