Highlight files after setFiles

[felixheidecke]

Description

Call file highlighting after files are redered to view

Related Issue

Fixes #28106

How Has This Been Tested?

Visual test in FF; Chrome, IE11 and MS Edge

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[PVince81]

This will likely re-highlight the file again every time the file list is reloaded, when navigating between folders.

I suggest setting _scrollTo to null as soon as the event has run.

[felixheidecke]

This will likely re-highlight the file again every time the file list is reloaded when navigating between folders.

That's true. I thought .one(… should do the trick but it didn't 👅
Anyway … updated :-)

[PVince81]

👍

Please backport to stable10

[felixheidecke]

Please backport to stable10

Never done this before. Whats the workflow?

[DeepDiver1975]

Never done this before. Whats the workflow?

https://gist.github.com/DeepDiver1975/33cde0c03f0c321132ca517cc5fbd580

[DeepDiver1975]

but first squash these commits together - THX

[phil-davis]

@DeepDiver1975 has his own magic script, but the process is:

• find the commit-id SHA in the list of commits in master (after the main PR to master has been squash-merged...) - there is a button to "Copy the full SHA" which is easy

git checkout stable10
git checkout -b stable10-fh_fix_permalink
git cherry-pick <commit-id>
git push

then go to GitHub make a PR from that branch, making sure to select stable10 as the to which to make the PR to.

Hmmm - @deep got there first.

[felixheidecke]

@PVince81 backport: #28681

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.