Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate persistent lock to federated instance #34222

Open
PVince81 opened this issue Jan 22, 2019 · 3 comments
Open

Propagate persistent lock to federated instance #34222

PVince81 opened this issue Jan 22, 2019 · 3 comments

Comments

@PVince81
Copy link
Contributor

Steps

  1. Setup OC_A and OC_B
  2. As admin@OC_A share a folder "test" with admin@OC_B
  3. On admin@OC_B, use the LOCK method and create an exclusive lock on the received "test" folder
  4. On admin@OC_A create a subfolder "test/sub"

Expected behavior

Folder creation denied.
Folder "test" must have the lock icon in the sidebar on both OC_A and OC_B.

Actual behavior

Folder creation goes through.
Lock icon only on OC_B which is the instance that locked.

Note: a similar scenario exists where OC_A sets the lock but OC_B doesn't see the lock icon/info.

To make this work we need rewrite the "*lock" methods in the DAV external storage connector to actually send LOCK methods to the remote server.

Also somehow we need to propagate the lock information through PROPFIND.

Versions

master

This means that currently when using federation, persistent locks are not guaranteed / not supported and must be documented as known limitation for now.

@DeepDiver1975 @pmaier1

@PVince81
Copy link
Contributor Author

this also implies that the LOCK verb is supported on the public webdav endpoint (used by public links and federation), which it is now on master.

cc @VicDeo

@ownclouders
Copy link
Contributor

GitMate.io thinks possibly related issues are #33886 (Allow admins to remove persistent locks), #34208 ([stable10] Fix persistent lock timeout behavior), #34100 (Fix persistent lock timeout behavior), #1303 (Federate ownCloud instances), and #33846 (Persistent lock timeout value must be remaining time).

@PVince81
Copy link
Contributor Author

For now the public webdav endpoint cannot lock or unlock, just use lock discovery: #34351

For federation we'll need to reenable, so make sure to check #34351 as we had test for public locking in the past which we should recover.

cc @individual-it

settermjd added a commit to owncloud/docs that referenced this issue Nov 19, 2019
settermjd added a commit to owncloud/docs that referenced this issue Nov 19, 2019
settermjd added a commit to owncloud/docs that referenced this issue Nov 19, 2019
settermjd added a commit to owncloud/docs that referenced this issue Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants