Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow admins to remove persistent locks #33886

Closed
PVince81 opened this issue Dec 13, 2018 · 6 comments
Closed

Allow admins to remove persistent locks #33886

PVince81 opened this issue Dec 13, 2018 · 6 comments

Comments

@PVince81
Copy link
Contributor

Currently persistent locks can only be removed by the lock owners.

It would be nice to also allow admins to remove such locks (aka "breaking the lock").
Prerequisite would be that admins also have access to the file through sharing.

Should subadmins also be able to unlock ?

@DeepDiver1975 @pmaier1

@ownclouders
Copy link
Contributor

GitMate.io thinks possibly related issues are #3260 (- Removed -), #240 (--- Removed ---), #5195 (Please allow Admins to masquerade as other users), #31651 (Adding persistent lock types to ILockingProvider), and #25307 (Allow admins to revoke authentication tokens).

@pmaier1
Copy link
Contributor

pmaier1 commented Dec 13, 2018

I'm not sure whether this is needed. I would find it way more important to enable the file owners to unlock them as
a) it's their file and
b) they decide intentionally to unlock it.

@PVince81
Copy link
Contributor Author

this only works for regular storages

for system-wide external storages there is no concept of file owner, so this would need to default to either everyone or just the admin.

@stale
Copy link

stale bot commented Sep 20, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status/STALE label Sep 20, 2021
@phil-davis
Copy link
Contributor

This is "effectively" coming in 10.9.
https://github.com/owncloud/enterprise/issues/4328

#38222

owncloud/docs#3962

Any user(s) can be put into the "lock breakers" group and can unlock files of other users that they can "see" (have received a share for)

@pmaier1 is that enough? or should admins get a right to unlock any file, if they need to?

@stale stale bot removed the status/STALE label Sep 20, 2021
@pmaier1
Copy link
Contributor

pmaier1 commented Sep 20, 2021

@pmaier1 is that enough? or should admins get a right to unlock any file, if they need to?

Yes, nothing else planned. Coming with 10.9. Closing therefore.

@pmaier1 pmaier1 closed this as completed Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants