Add warning on update that an app's code is missing

[PVince81]

When loading apps during an upgrade, first check whether the app's code is really there.

For example if user_ldap is missing but is enabled, if someone runs an upgrade the repair steps will miss the LDAP users silently.

Best would be to be more strict here and stop the upgrade early.

This happened to me while testing an update from git v9.1.1 to master and forgot to check out the user_ldap repo on master.

@DeepDiver1975 @butonic @VicDeo

[PVince81]

I suppose this kind of situation could also happen when people upgrade using tarballs and forget to also move over the installed apps code. This is especially important for authentication apps.

[PVince81]

@VicDeo can you look into this ? Goal is mostly to make sure that we're not breaking up

Let me know if you need help to setup LDAP quickly for the sake of testing. I usually use this docker https://github.com/owncloud/administration/tree/master/ldap-testing + zombies.

To reproduce the issue:

1. Checkout stable9.1 where LDAP is bundled
2. Set it up
3. Setup LDAP with some users
4. Checkout master but do NOT check out the user_ldap app (it's not bundled any more)
5. Run upgrade in verbose mode
6. Check the logs / progress and see whether LDAP users were iterated over, they are likely not

Expected result

Before the upgrade, when loading authentication apps, notice that code is missing and abort

Actual result

Upgrade runs but repair steps do not run on LDAP users since the app is missing.

[VicDeo]

@PVince81 Should it abort for any missing app or user_ldap only?

[PVince81]

I'd say for any app that is expected to be there.

[PVince81]

was added in 10.0.0

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.