[master] LDAP app not loaded during upgrade

[PVince81]

Observed while running #26124

The UserManager object only iterates over local users.

Debugging showed that this call https://github.com/owncloud/core/blob/master/lib/private/Updater.php#L283 doesn't load any apps because loadApps checks for the maintenance flag and skips loading.

@DeepDiver1975 has anything changed here recently ?

[PVince81]

Okay, easier steps:

1. Enable LDAP app and it up so it has users
2. Increase version in version.php
3. Set a breakpoint at https://github.com/owncloud/core/blob/master/lib/private/Updater.php#L283
4. Run occ upgrade
5. Debug into loadApps and see that it returns directly.

[DeepDiver1975]

@DeepDiver1975 has anything changed here recently ?

nothing I can think of right away ...

[PVince81]

I'm not yet 100% sure it's that loadApps call. When debugging on 9.1 it seems to also skip but worked because maybe it was enabled before.

In general it does seem that loadApps('authentication') never does anything so it doesn't fulfil its purpose.

[PVince81]

silly me, I forgot that user_ldap is now in a separate repo...

Not critical then.

However it is still suspicious that loadApps('authentication') doesn't do anything, could hide potential issues.

[PVince81]

Raised #26227 for an addition update check to make sure all auth apps are loaded.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.