Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating a password using OCS Share API changes the share ID #10671

Closed
Azelphur opened this issue Aug 27, 2014 · 5 comments
Closed

Updating a password using OCS Share API changes the share ID #10671

Azelphur opened this issue Aug 27, 2014 · 5 comments
Labels
feature:sharing sev3-medium Type:Bug
Milestone
8.1

Comments

@Azelphur
Copy link
Collaborator

If you make an API call using the OCS Share API and set a password on a share, it appears to change the share ID. Not sure if this is intended or not.

Paging @PVince81 as requested.
@PVince81
Copy link
Contributor

@schiesbn can you have a look ? If I remember well you did address something similar recently ?

@PVince81
Copy link
Contributor

This seems to happen in the web UI as well.

  1. Open share dropdown
  2. Set expiration date first
  3. Close then reopen the dropdown: date is there
  4. Set a password
  5. Close then reopen the dropdown: date is gone

@MTRichards MTRichards added this to the 2014-sprint-04-next milestone Sep 5, 2014
@craigpg craigpg modified the milestones: 2014-sprint-05-next, 2014-sprint-04-current Sep 15, 2014
@craigpg craigpg modified the milestones: 2014-sprint-06-next, 2014-sprint-05-current Sep 29, 2014
@craigpg craigpg modified the milestones: 2014-sprint-07-next, 2014-sprint-06-current Oct 12, 2014
@craigpg craigpg modified the milestones: 2014-sprint-08-next, 2014-sprint-07-current Oct 27, 2014
@PVince81 PVince81 mentioned this issue Oct 30, 2014
Closed
1 task
@craigpg craigpg modified the milestones: 2014-sprint-09-next, 2014-sprint-08-current Nov 10, 2014
LukasReschke added a commit that referenced this issue Nov 17, 2014
@LukasReschke
Remove phpass and migrate to new Hasher interface
8595b76 
This PR removes phpass and migrates to the new Hasher interface.

Please notice that due to #10671 old hashes are not updated but the hashes are backwards compatible so this shouldn't hurt.
Once the sharing classes have a possibility to update the passwords of single shares those methods should be used within the newHash if block.
@LukasReschke LukasReschke mentioned this issue Nov 17, 2014
Merged
@DeepDiver1975 DeepDiver1975 modified the milestones: 2014-sprint-09-next, backlog Jan 31, 2015
@PVince81 PVince81 mentioned this issue Feb 4, 2015
Closed
@PVince81 PVince81 modified the milestones: 8.1-next, backlog Feb 4, 2015
@PVince81
Copy link
Contributor

PVince81 commented Feb 4, 2015

@DeepDiver1975 moved to 8.1

This was referenced Mar 12, 2015
Open
Closed
@rullzer rullzer mentioned this issue Mar 13, 2015
Closed
7 tasks
@rullzer
Copy link
Contributor

rullzer commented Mar 13, 2015

WIP PR in #14868

@rullzer rullzer mentioned this issue Mar 18, 2015
Merged
@DeepDiver1975 DeepDiver1975 modified the milestones: 8.1-current, 8.2-next Apr 4, 2015
@MorrisJobke
Copy link
Contributor

Fixed in #14987

@MorrisJobke MorrisJobke modified the milestones: 8.1-current, 8.2-next Apr 8, 2015
@MorrisJobke MorrisJobke mentioned this issue May 27, 2015
Closed
yparam98 added a commit to yparam98/core that referenced this issue Sep 19, 2018
@yparam98
Removes empty code block...
e3b7ed3 
line(s) 143-145

removed it

code before:

    * to update the share's password. (for example `$share->updatePassword($password)`
	    				 *
		    			 * @link owncloud#10671
			    		 */
				    	if (!empty($newHash)) {
				    	}
				    	//
	    			} else {
	    				return false;
felixheidecke pushed a commit that referenced this issue Oct 31, 2018
@yparam98 @felixheidecke
Removes empty code block...
3f7bc9a 
line(s) 143-145

removed it

code before:

    * to update the share's password. (for example `$share->updatePassword($password)`
	    				 *
		    			 * @link #10671
			    		 */
				    	if (!empty($newHash)) {
				    	}
				    	//
	    			} else {
	    				return false;
@lock lock bot locked as resolved and limited conversation to collaborators Aug 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature:sharing sev3-medium Type:Bug
Projects
None yet
Milestone
8.1
Development

Successfully merging a pull request may close this issue.

Allow updating of password on public share
7 participants
@rullzer @craigpg @MorrisJobke @PVince81 @Azelphur @DeepDiver1975 @MTRichards