Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra args when sharing with link #71

Open
PVince81 opened this issue Feb 8, 2015 · 11 comments
Open

Extra args when sharing with link #71

PVince81 opened this issue Feb 8, 2015 · 11 comments
Assignees
Milestone

Comments

@PVince81
Copy link
Contributor

PVince81 commented Feb 8, 2015

Add **kwargs to share_file_with_link with the following:

  • perms for permissions or public_upload
  • password for the share password
  • expiration for expiration
@SergioBertolinSG
Copy link
Contributor

Facing this problem when trying to update a shared folder with a password and an expiration date
owncloud/core#14826

@PVince81
Copy link
Contributor Author

Ah yes, the password thing... Actually when you change the password it will recreate a new share... see owncloud/core#10671

@PVince81
Copy link
Contributor Author

I think the bug was fixed so you should be able to add the call now.

Question is still open about what to do with OC <= 8.1, whether to put a workaround there... I'd say ignore for now.

@PVince81
Copy link
Contributor Author

@SergioBertolinSG did you intend to submit a PR ?
I think the "recreate share when changing password" issue was fixed, but need to double check in which versions.

@SergioBertolinSG
Copy link
Contributor

@PVince81 I didn't have the time sorry, I'll try to prepare one today, we'll need this to test the new password policy feature.

@SergioBertolinSG
Copy link
Contributor

Expiration date is not available yet in the OCS Sharing API.

@PVince81
Copy link
Contributor Author

Is there a ticket in core to request it ?

@SergioBertolinSG
Copy link
Contributor

yes this one owncloud/core#14808

@PVince81
Copy link
Contributor Author

PR here #120

@SergioBertolinSG
Copy link
Contributor

@PVince81
Copy link
Contributor Author

Expiration is missing, that's what my PR adds

@PVince81 PVince81 modified the milestones: 0.3, 0.2 May 24, 2016
@PVince81 PVince81 modified the milestones: 0.3, 0.5 Jan 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants