Instantupload

[masensio]

No description provided.

[ickeundso]

Hello,

@davivel, since this merge is done, showing the first screen takes a
long time.

Now have checked out the develop branch and I can see the slow behavior
of the app.
Show the files and folder with there detail informations is not only
slowing down the app, I can also see a huge GC -logs.

Is this a know bug, is someone working on?

Matthias

On 13.06.2013 13:31, masensio wrote:

---

    You can merge this Pull Request by running

git pull https://github.com/owncloud/android instantupload

Or view, comment on, or merge it at:

#181

    Commit Summary

• merge in develop branch

• fix InstantUploadActivity crashes when the device orientation changes. #137-InstantUploadActivity crashes when the device orientation

• Merge branch 'develop' into instantupload

  File Changes
  

• M res/layout-land/account_setup.xml
  https://github.com/owncloud/android/pull/181/files#diff-0 (4)

• M res/layout/account_setup.xml
  https://github.com/owncloud/android/pull/181/files#diff-1 (4)

• M res/layout/failed_upload_files.xml
  https://github.com/owncloud/android/pull/181/files#diff-2 (97)

• M res/values/strings.xml
  https://github.com/owncloud/android/pull/181/files#diff-3 (2)

• M
  src/com/owncloud/android/authentication/AuthenticatorActivity.java
  https://github.com/owncloud/android/pull/181/files#diff-4 (180)

• M src/com/owncloud/android/files/services/FileDownloader.java
  https://github.com/owncloud/android/pull/181/files#diff-5 (1)

• M src/com/owncloud/android/files/services/FileUploader.java
  https://github.com/owncloud/android/pull/181/files#diff-6 (1)

• M src/com/owncloud/android/ui/activity/FileDetailActivity.java
  https://github.com/owncloud/android/pull/181/files#diff-7 (4)

• M src/com/owncloud/android/ui/activity/FileDisplayActivity.java
  https://github.com/owncloud/android/pull/181/files#diff-8 (2)

• M
  src/com/owncloud/android/ui/activity/InstantUploadActivity.java
  https://github.com/owncloud/android/pull/181/files#diff-9 (70)

  Patch Links:
  

• https://github.com/owncloud/android/pull/181.patch

• https://github.com/owncloud/android/pull/181.diff

[davivel]

Seems that the problem in performance comes from the recent addition of size of folders in the list. We need to change that implementation to something that does not calculate the size in the momento of showing the views.

1. The size for every folder should be calculated and saved in database in sychronizations.
2. The list of files should show the size as cached in the database, although could be obsolete.

Later, we should improve this by adding automatic synchronization of the current folder on browsing, as it is already requested in some other issue.

As far as I know, nobody is working right now in these improvements.

But before start with it, maybe you want to have a look to the commentaries I am adding right now about this pull request.

EDIT: and the most important of the comments, below all the comments-in-code.

[davivel]

Why singleTop ? This can affect the workflow of the app.

[ickeundso]

maybe this is a wrong way, but I had the problem when the activity was
already open an I clicked to a new failure notification, the activity was
opened twice.

Am 1. Juli 2013 10:20:12 schrieb "David A. Velasco" notifications@github.com:

@@ -59,7 +59,8 @@

•   <activity android:name=".ui.activity.InstantUploadActivity">
  

•   <activity android:name=".ui.activity.InstantUploadActivity"
  

•       android:launchMode="singleTop">
  

Why singleTop ? This can affect the workflow of the app.

---

Reply to this email directly or view it on GitHub:
https://github.com/owncloud/android/pull/181/files#r4957685

[davivel]

I am very sad about this, seems you did a great job improving this activity. But the thing is, this is coming late.

At this moment we are actively working in provide a better upload service so that any failed upload (not just instant uploads) is automatically recovered when no input of the user is needed for it.

That doesn't mean we don't want an activity where failed uploads are listed and may be manually retried ... indeed, it is in the backlog. We want a view where the user can access, specially, to the failed uploads that need some kind of input to be retried. But we definitely don't want that this activity deals only with instant uploads of pictures, but rather with any kind of upload.

It is still work in progress, but the branch offline_uploads_new_file is getting the code for allowing file uploads although there is no network connection. By now, we just added a couple of fields in the general database of files so that we can keep track of what files should be 'uploading' or 'downloading'. Maybe in the near future we create a separate table for adding more information about an upload in progress, but we will probably get rid of the database where instant uploads are now being saved (your code accesses them through DbHandler), because there is no point in that the table is in a separated database.

In summary: although you change the things I commented directly about the code, We don't know what to do with this pull request. We don't want to lose your collaboration, but this code only will have sense for being released in the app if we keep on changing it until it covers all kind of uploads (images or not). Let us know if that would be nice for you.

[ickeundso]

thanks, but don't worry about your plans with the code, I jave some things
learned about android, this is the main reasons for me to contribute., ok
also the whole idea of owncloud.

but I think it is easy. to use this activity with an other table/database.
and other entry points.

Am 1. Juli 2013 10:55:12 schrieb "David A. Velasco" notifications@github.com:

I am very sad about this, seems you did a great job improving this
activity. But the thing is, this is coming late.

At this moment we are actively working in provide a better upload service
so that any failed upload (not just instant uploads) is automatically
recovered when no input of the user is needed for it.

That doesn't mean we don't want an activity where failed uploads are listed
and may be manually retried ... indeed, it is in the backlog. We want a
view where the user can access, specially, to the failed uploads that need
some kind of input to be retried. But we definitely don't want that this
activity deals only with instant uploads of pictures, but rather with any
kind of upload.
It is still work in progress, but the branch offline_uploads_new_file is
getting the code for allowing file uploads although there is no network
connection. By now, we just added a couple of fields in the general
database of files so that we can keep track of what files should be
'uploading' or 'downloading'. Maybe in the near future we create a separate
table for adding more information about an upload in progress, but we will
probably get rid of the database where instant uploads are now being saved
(your code accesses them through DbHandler), because there is no point in
that the table is in a separated database.
In summary: although you change the things I commented directly about the
code, We don't know what to do with this pull request. We don't want to
lose your collaboration, but this code only will have sense for being
released in the app if we keep on changing it until it covers all kind of
uploads (images or not). Let us know it that would be nice for you.

---

Reply to this email directly or view it on GitHub:
#181 (comment)