UI improvements in InstantUploadActivity

[davivel]

• Text size is too small.
• The activity should keep the title / action bar as all the file related activities.
• When the user selects 'Upload' in the options menu, the entry 'Failed InstantUpload' should not be there unless there are failed uploads to recover.
• The menu entry should say something like 'Failed instant uploads' ; the word 'InstantUpload' is not regular English.

[zerginator]

@davivel why we need this activity at all ? If a instantUpload is not working it will be retried after the connection is established. We just need a listener which checks if the connection is there ? Or did I miss something ?

[davivel]

@zerginator The problem is that the automatic recovery is not always working fine. Repairing this one would be a preferable solution, but maybe a bit harder. Or maybe not.

As stated in some issue over there, the automatic recovery is triggered when a new Wi-Fi connection is got. There are two problems in this:

1. The instant uploads can fail due to other reasons not related with lack of Wi-Fi; getting a new Wi-Fi connection may be an interesting trigger, but not necessary enough.
2. Getting a new Wi-Fi does not mean have access to ownCloud server; the automatic recovery will fail again in this case, for every single file.

[zerginator]

to 1. I'm reviewing the code of this. What could be a solution for this ? Check every 15 min if we have access to the server ?

If (InstantUploadEnabled && online && (ping from server == true) )
If (onlyWifi && WifiIsEnabled)
upload!
else if ( !onlyWifi ) {
upload!
}
else {
error!
}

[zerginator]

the 15 min check will only be done if there are some files waiting for upload

[davivel]

No, please, don't define arbitrary polling periods to check. Just adding some other events, such as a new synchronization started or the main activtiy is created.

[ickeundso]

In my opinion, it is not every time the best solution to try to automate something.
At the case something goes wrong the user should have the option to get more informations about the failures and the possibilities to react on in different ways.

[ickeundso]

Text size is too small. --> what is the smallest size you can go with.
Do you mean only the failure messages at the left or also the button texts?

[davivel]

Text in the list should be the same size that in the regular list of files. Same for buttons.

[davivel]

This activtiy was finally discarded.