Instant upload tries and fails when connected to a wireless network without internet connection

[skpy]

I have Instant Upload enabled for the Android ownCloud client, and have selected "WiFi only". There are a lot of open WiFi networks nearby which require some sort of sign-in. The ownCloud client seems to not pay attention to this fact. As soon as a WiFi network is negotiated on my phone, the ownCloud client tries to upload new photos. It fails because I haven't completed the sign-in process.

An example of this is Starbucks: all of their WiFi SSIDs are "ATT Wifi" (or something similar). My phone remembers this SSID and happily connects to the network. Before I can actually access the Internet, though, I have to open a browser and click on an "I agree" button presented on a splash page.

It would be ideal if the ownCloud client would try to confirm that it can communicate with the ownCloud server in some fashion before trying to upload photos.

[davivel]

Interesting. Thanks for the suggestion.

[untitaker]

Does the client recover from connection errors? Because in that case i wouldn't think it's a big issue.

[skpy]

The Instant Upload feature tries and tries and tries to upload the
photo(s), generating a failure notification for each attempt. When I leave
the range of the captive portal WiFi network, Instant Upload finally stops
trying. When I connect to a trusted network with no captive portal, I
believe the photo(s) uploads correctly. I'll have to test again to find
out, because I'm honestly not sure...

In my opinion, a connection attempt should be made before uploading. If no
connection is possible, don't bother trying to upload (and spare me the
unnecessary failure notifications).

On Fri, Jan 25, 2013 at 7:01 AM, Markus Unterwaditzer <
notifications@github.com> wrote:

Does the client recover from connection errors? Because in that case i
wouldn't think it's a big issue.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/64#issuecomment-12698172.

[laryllian]

True, there should only be a failure notice, if the oc instance can be reached but the pic cannot be (fully?) uploaded. Anything else does not make any sense to me.

[RandolfCarter]

Anything else does not make any sense to me.

Yep, +1 from my side - maybe it's just me who's strict on this, but I would consider any other behaviour a bug ;). Also, all instant upload of any other software I know of behave that way...

[davivel]

Please, let me edit a bit the title of this issue .

[vincentqb]

The problem described in #231 is that if the Android application is not running (force closed for instance) then there are no notifications about failed upload, and the files are not ever sent to the server.

[davivel]

We are working in a general solution to recover failed uploads, no matter if 'instant' or not, no matter if notified or not. It is in the branch offline_recover_failed_uploads_without_user_intervention , that comes from offline_upload_new_file (if I remember right).

We had to put this in pause a couple of weeks ago for other feature. We plan to resume the work here as soon as possible. We are aware that problems with uploads are very important now, but want to fix them in a global way.

All of you who are able to fetch and build the code, feel free to experiment with these branches.

[laryllian]

What a crazy title ;) Pls change it to something like "Instant upload tries and fails when connected to a wireless network without internet connection". That sums up the underlying problem, since the critisised behaviour would also occur in a company intranet-only wireless network etc. This problem has nothing to do with interrupted uploads directly, but with reachability of the oc server.

[davivel]

Ok, your English is much more inspired than mine :)

[laryllian]

@davivel
Thx, glad I could help ;-)

[masensio]

I think the issue #826 will help to solve this problem.

[tobiasKaminsky]

I think this can be closed as failed errors due to the scenario described can easily be retried

[tobiasKaminsky]

even better:
https://developer.android.com/training/monitoring-device-state/connectivity-monitoring.html
boolean isConnected = activeNetwork != null &&
activeNetwork.isConnectedOrConnecting();

This should be checked before every upload.
Then the upload just won't start if it is a wifi connection without internet

[mueller-ma]

Then the upload just won't start if it is a wifi connection without internet

If I'm on my wifi and internet is down, it would annoy me if the oc client doesnt want to sync to my local oc server.
And whats even worse: I use a client side firewall to block some traffic and increase privacy. Since the internet check requires a connection to google I blocked it, so all wifis are tagged as no internet.

I think its better to try to reach the server instead and retry after some time if the server is unavailable.