AO3-4308 Update claim email text with t's suggestion #4796
Conversation
| @@ -25,7 +25,7 @@ | |||
| <% end %> | |||
| </ul> | |||
|
|
|||
| <p><%= t(".redirects") %></p> | |||
| <p><%= t(".redirects_html") %></p> | |||
There was a problem hiding this comment.
Would be nice to have the locale keys be redirects.html and redirects.text for consistency with other mailer keys. See also #4519 (comment).
There was a problem hiding this comment.
Note: This is a nitpick. If getting this merged is very high priority, the rest of the commit looks good and this could be merged as is.
|
(marking as action needed again after some discussion with @sarken elsewhere) |
|
It's not clear to me whether this still applies, but in a past PR it was preferred to have a html and text version of a html safe key even when they use the same English text. |
|
(I left a note with Translation to check if they needed separate versions ~3 hours ago, but I've got to go to sleep -- I'll let you know what they say when I have a chance. If we're in a hurry, though, I'd err on the side of separate versions.) |
|
All good, thank you! |
Pull Request Checklist
Issue
https://otwarchive.atlassian.net/browse/AO3-4308