Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AO3-6240 Use i18n-tasks to rename numbered mailer translation keys #4519

Merged
merged 5 commits into from
Jun 2, 2023

Conversation

Bilka2
Copy link
Contributor

@Bilka2 Bilka2 commented May 25, 2023

Pull Request Checklist

Issue

https://otwarchive.atlassian.net/browse/AO3-6240

Purpose

Rename numbered locale keys used by the mailers.

Testing Instructions

See comment on Jira issue.

References

#4497 for moving instructions, will add them to the wiki once this PR is reviewed.

Credit

Bilka (he/him)

@Bilka2
Copy link
Contributor Author

Bilka2 commented Jun 2, 2023

Duplicate (copy and rename) locale key:

  • Uncomment the data write config in config/i18n-tasks.yml line 25
  • Comment the data read config in config/i18n-tasks.yml line 18
  • Run bundle exec i18n-tasks data -f yaml | bundle exec i18n-tasks tree-mv -a 'user_mailer.change_email.changed.html' 'user_mailer.change_email.changed.text' -f yaml | bundle exec i18n-tasks data-merge
  • Undo the changes to config/i18n-tasks.yml
  • Manually duplicate the English key

Update any relevant views.

Copy link
Collaborator

@sarken sarken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you so much!

@sarken sarken merged commit 35ce690 into otwcode:master Jun 2, 2023
@Bilka2 Bilka2 deleted the AO3-6240 branch June 4, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants