Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AO3-6608 Update delete icon checkbox text #4794

Merged
merged 1 commit into from
Apr 20, 2024

Conversation

smclairecarden
Copy link
Contributor

@smclairecarden smclairecarden commented Apr 20, 2024

Pull Request Checklist

Issue

https://otwarchive.atlassian.net/browse/AO3-6608

Delete icon alt and comment text when deleting icon. I forgot to update the checkbox text.

Purpose

What does this PR do?

Updates the checkbox text when deleting psued icons and alt text - Sorry this took so long!

Testing Instructions

How can the Archive's QA team verify that this is working as you intended?

If you have a Jira account with access, please update or comment on the issue
with any new or missing testing instructions instead.

See jira.

References

Are there other relevant issues/pull requests/mailing list discussions?

Credit

What name and pronouns should we use to credit you in the Archive of Our Own's Release Notes?

Claire C she/her.

If you have a Jira account, please include the same name in the "Full name"
field on your Jira profile, so we can assign you the issues you're working on.

Please note that if you do not fill in this section, we will use your GitHub account name and
they/them pronouns.

@github-actions github-actions bot added Scope: i18n Only Only moves text to en.yml for i18n purposes Awaiting Review labels Apr 20, 2024
@brianjaustin brianjaustin changed the title AO3-6608 - Update Checkbox Text. AO3-6608 Update delete icon checkbox text Apr 20, 2024
@brianjaustin brianjaustin merged commit 30b8ac7 into otwcode:master Apr 20, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: High - Broken on Test Merge immediately after approval Reviewed: Ready to Merge Scope: i18n Only Only moves text to en.yml for i18n purposes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants