AO3-5578 Use ActiveStorage for existing image uploads

[brianjaustin]

Pull Request Checklist

Issue

https://otwarchive.atlassian.net/browse/AO3-5578

Purpose

Migrate existing places that use kt-paperclip to ActiveStorage (pseud, collection, and skin icons)

Credit

Brian Austin (they/he)

[brianjaustin]

Because ActiveStorage doesn't support prefixes within buckets well, we'll need to update the Ansible local config to separate things out IMO that's better anyways, since we currently co-mingle some production and non-production things... 😬 There's probably a way to do this with less friction, but I think this should be OK since we're copying things over

[Bilka2]

Because ActiveStorage doesn't support prefixes within buckets well, we'll need to update the Ansible local config to separate things out IMO that's better anyways, since we currently co-mingle some production and non-production things...

Looks like #4738 (AO3-6324' comments) agree with you.

[Bilka2]

I had a look at all the code except for the rake task.

The fixtures in test/fixtures/pseuds.yml have (empty) lines for icon_file_name, icon_content_type, icon_updated_at and icon_file_size that should probably be removed.

I think there should be a followup Jira issue to remove the icon_file_name, icon_content_type, icon_updated_at and icon_file_size columns from the database for the affected classes.

[Bilka2]

A few final comments. The rake task looks good, as does the rest of the code.

I also tried a few things in local dev, including looking at various icons in various places, uploading a pseud icon and using that to test the validator and resizing. Resizing acts the same as on production.

[Bilka2]

I think I found how to fix the tests.

[Bilka2]

Just some more nitpicks, then this is finally done!

[Bilka2]

🎉 🎉 🎉

[Bilka2]

You can remove the imagemagick installation from the automated tests, ActiveStorage replaces it with libvips. (Test run with the removal: https://github.com/Bilka2/otwarchive/actions/runs/12524953209)

[Bilka2]

Also, regarding proxy requests, https://guides.rubyonrails.org/v7.0/active_storage_overview.html#putting-a-cdn-in-front-of-active-storage has a section on making the URL is the CDN host instead of the app host. Is that something we would want to add as well? I would assume no, since cloudflare is in front of the app, not the CDN.

[brianjaustin]

Also, regarding proxy requests, https://guides.rubyonrails.org/v7.0/active_storage_overview.html#putting-a-cdn-in-front-of-active-storage has a section on making the URL is the CDN host instead of the app host. Is that something we would want to add as well? I would assume no, since cloudflare is in front of the app, not the CDN.

I asked @AlbertSPedersen about that, and he said we can have CloudFlare reroute the request to either cache/hit S3 directly as long as it's using an ao3.org URL. So yeah, we don't need to do the extra CDN step in this case

[sentry-io]

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

• ‼️ ActiveRecord::ConnectionNotEstablished: Can't connect to MySQL server on '127.0.0.1' (115) CollectionsController#index View Issue

_{Did you find this useful? React with a 👍 or 👎}