Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AO3-6503 Allow superadmins to disable guest comments across the site #4492

Merged
merged 19 commits into from
Jun 19, 2023
Merged

AO3-6503 Allow superadmins to disable guest comments across the site #4492

merged 19 commits into from
Jun 19, 2023

Conversation

EchoEkhi
Copy link
Contributor

@EchoEkhi EchoEkhi commented Apr 8, 2023 •
edited
Loading

Pull Request Checklist

Todo

  • Fix weird bug where the reply to comment function doesn't work

Issue

https://otwarchive.atlassian.net/browse/AO3-6503

Purpose

Allow superadmins to disable guest comments across the site.

Testing Instructions

See JIRA ticket.

Credit

EchoEkhi

@github-actions github-actions bot added Has Migrations Contains migrations and therefore needs special attention when deploying Awaiting Review labels Apr 8, 2023
sarken
sarken requested changes May 17, 2023
View reviewed changes
Copy link
Collaborator

@sarken sarken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this!

features/admins/admin_settings.feature Outdated Show resolved Hide resolved
app/controllers/comments_controller.rb Outdated Show resolved Hide resolved
spec/controllers/comments_controller_spec.rb Show resolved Hide resolved
spec/controllers/comments_controller_spec.rb Show resolved Hide resolved
sarken
sarken reviewed May 26, 2023
View reviewed changes
app/models/admin_setting.rb Outdated Show resolved Hide resolved
app/helpers/comments_helper.rb Outdated Show resolved Hide resolved
features/admins/admin_settings.feature Outdated Show resolved Hide resolved
features/admins/admin_settings.feature Outdated Show resolved Hide resolved
features/admins/admin_settings.feature Outdated Show resolved Hide resolved
features/admins/admin_settings.feature Outdated Show resolved Hide resolved
features/admins/admin_settings.feature Outdated Show resolved Hide resolved
features/admins/admin_settings.feature Outdated Show resolved Hide resolved
features/admins/admin_settings.feature Outdated Show resolved Hide resolved
spec/controllers/comments_controller_spec.rb Show resolved Hide resolved
sarken
sarken reviewed May 29, 2023
View reviewed changes
app/controllers/comments_controller.rb Outdated Show resolved Hide resolved
app/views/comments/_commentable.html.erb Outdated Show resolved Hide resolved
features/admins/admin_settings.feature Outdated Show resolved Hide resolved
features/admins/admin_settings.feature Outdated Show resolved Hide resolved
features/admins/admin_settings.feature Outdated Show resolved Hide resolved
spec/controllers/comments_controller_spec.rb Outdated Show resolved Hide resolved
spec/controllers/comments_controller_spec.rb Show resolved Hide resolved
sarken
sarken reviewed Jun 10, 2023
View reviewed changes
features/admins/admin_settings.feature Outdated Show resolved Hide resolved
features/admins/admin_settings.feature Outdated Show resolved Hide resolved
spec/controllers/comments_controller_spec.rb Outdated Show resolved Hide resolved
spec/controllers/comments_controller_spec.rb Outdated Show resolved Hide resolved
spec/controllers/comments_controller_spec.rb Outdated Show resolved Hide resolved
@sarken sarken merged commit 754e816 into otwcode:master Jun 19, 2023
@ceithir ceithir mentioned this pull request Jun 30, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tickinginstant tickinginstant tickinginstant left review comments

@sarken sarken sarken approved these changes

Assignees
No one assigned
Labels
Has Migrations Contains migrations and therefore needs special attention when deploying Priority: High Reviewed: Ready to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EchoEkhi @sarken @tickinginstant