AO3-5860 Prevent leaving comments or kudos when logged in as admin #4378
Conversation
|
As of now, I've restricted admins only from commenting on works. Not sure if this should be extended to some other types of commentable (chapters?). |
|
Thanks for working on this! And my apologies; I thought I had replied to this days ago. It looks like the issue wasn't entirely clear about the scope -- admins shouldn't be able to leave comments or kudos on anything, period. (Volunteers are expected to use user accounts with the official role for communication with users.) The comment form should also be hidden, not just the button. |
Not exactly sure why I wrote it in the first place honestly...
This reverts commit 5ddfb2e.
To make sure each takes forever due to silly mistakes
|
Conflict with #4492 technically solved. Unsure if it also implies some behavior changes here however. |
|
I can't think of any changes we'd need off the top of my head! |
In for a penny
| @@ -51,8 +51,8 @@ | |||
| (<%= allowed_html_instructions %>) | |||
| </h4> | |||
| <% else %> | |||
| <h4 class="heading"><%= ts("Comment as") %> <span class="byline"><%= current_user.default_pseud.name %></span> | |||
| <%= f.hidden_field :pseud_id, :value => "#{current_user.default_pseud.id}", :id => "comment_pseud_id_for_#{commentable.id}" %> | |||
| <h4 class="heading"><%= t(".comment_as") %> <span class="byline"><%= current_user.default_pseud.name %></span> | |||
There was a problem hiding this comment.
Not sure on this, but making a note anyway:
Normally we prefer putting variables into the translation string with interpolation instead concatenating in the view files. But that would make the translation not reusable for the multiple pseud case and the formatting looks it'd be a bit awkward to fit in. So I think this is fine to keep like this.
You might as well do it right
| <% else %> | ||
| <span><%= ts("to") %> <%= get_commenter_pseud_or_name(commentable) %> <%= ts("on") %> <%= commentable_description_link(commentable) %></span> | ||
| <% end %> | ||
| <span><%= t ".inbox_reference", |
There was a problem hiding this comment.
(In both spots) this translation key needs to be ".inbox_reference_html" so that the html of the links is not escaped. According to the i18n wiki page, the t function call should use parens ().
There was a problem hiding this comment.
According to the i18n wiki page, the t function call should use parens ().
Might be good to add it to Rubocop then? I'm not sure if there's an elegant way to force https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Style/MethodCallWithArgsParentheses for a single specific function.
Pull Request Checklist
AO3-1234 Fix thing)Issue
https://otwarchive.atlassian.net/browse/AO3-5860
Purpose
Enjoin admins to log out before leaving a comment or kudo.
More exactly:
Hide the relevant buttons as long as they're logged as admin
Return an error message in case such a request reaches the back regardless
Testing Instructions
See JIRA issues (including comments).
Credit
Ceithir (he/him)