Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Domain Event handling improvements #14

Merged
merged 1 commit into from
Jan 27, 2021

Conversation

othercodes
Copy link
Owner

@othercodes othercodes commented Jan 27, 2021

  • Now the Aggregate interface has the publishDomainEvent() method.
  • Small improvements in Event class.
  • Now HasDomainEvents traits has a new implementation of publishDomainEvents() method.
  • Added new isBound() method to HasServiceBus trait.
  • HasDomainEventTest updated.
$aggregate->publishDomainEvents($eventBus);

@codecov
Copy link

codecov bot commented Jan 27, 2021

Codecov Report

❗ No coverage uploaded for pull request base (develop@6475e30). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop      #14   +/-   ##
==========================================
  Coverage           ?   83.21%           
  Complexity         ?      137           
==========================================
  Files              ?       21           
  Lines              ?      292           
  Branches           ?        0           
==========================================
  Hits               ?      243           
  Misses             ?       49           
  Partials           ?        0           
Flag Coverage Δ Complexity Δ
unittests 83.21% <0.00%> (?) 0.00% <0.00%> (?%)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6475e30...b4de74e. Read the comment docs.

- Now the Aggregate interface has publishDomainEvent() method.
- Small improvements in Event class.
- Now HasDomainEvents traits has new implementation of publishDomainEvents() method.
- Added new isBound() method to HasServiceBus trait.
- HasDomainEventTest updated.
@othercodes othercodes force-pushed the feature/DomainEventHandlingImprovements branch from 4a720f6 to b4de74e Compare January 27, 2021 15:26
@othercodes othercodes requested a review from segoddnja January 27, 2021 15:26
@othercodes othercodes self-assigned this Jan 27, 2021
@othercodes othercodes added the enhancement New feature or request label Jan 27, 2021
@othercodes othercodes merged commit f38812d into develop Jan 27, 2021
@othercodes othercodes deleted the feature/DomainEventHandlingImprovements branch January 27, 2021 15:32
@othercodes othercodes mentioned this pull request Feb 10, 2021
othercodes added a commit that referenced this pull request Feb 10, 2021
* Feature/Added support for key types on Collections. (#12)
* Bugfix/Set mixed as default type for keys in collection. (#13)
* Feature/Domain Event handling improvements. (#14)
* Feature/QueryBus ask methods now has Response as return type. (#15)
* Feature/Added wiki auto-publish action. (#16)
* Feature/Extended documentation. (#17)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant