Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Added support for key types on Collections. #12

Merged
merged 1 commit into from
Jan 22, 2021

Conversation

othercodes
Copy link
Owner

  • Collection::typeOf renamed to Collection::valueType.
  • Added Collection::keyType.
  • Added invariant methods to check key types.

- Collection::typeOf renamed to Collection::valueType.
- Added Collection::keyType.
- Added invariant methods to check key types.
@codecov
Copy link

codecov bot commented Jan 22, 2021

Codecov Report

Merging #12 (ec622c5) into main (3e97fe4) will increase coverage by 1.09%.
The diff coverage is 76.59%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #12      +/-   ##
============================================
+ Coverage     82.81%   83.90%   +1.09%     
- Complexity      117      135      +18     
============================================
  Files            20       21       +1     
  Lines           256      292      +36     
============================================
+ Hits            212      245      +33     
- Misses           44       47       +3     
Flag Coverage Δ Complexity Δ
unittests 83.90% <76.59%> (?) 0.00 <24.00> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
src/Domain/ValueObjects/EnumValue.php 0.00% <0.00%> (ø) 8.00 <2.00> (+1.00)
src/Domain/ValueObjects/UUIDValue.php 84.61% <33.33%> (-15.39%) 7.00 <3.00> (+1.00) ⬇️
src/Domain/Collection.php 100.00% <100.00%> (ø) 16.00 <16.00> (?)
src/Domain/Criteria/Filter.php 100.00% <100.00%> (ø) 9.00 <3.00> (ø)
src/Domain/Traits/HasInvariants.php 100.00% <0.00%> (+4.16%) 9.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f065a66...ec622c5. Read the comment docs.

@othercodes othercodes changed the base branch from main to develop January 22, 2021 11:02
@othercodes othercodes merged commit 806de06 into develop Jan 22, 2021
@othercodes othercodes deleted the Feature/Add-support-for-key-types-in-collection branch January 22, 2021 11:03
@othercodes othercodes mentioned this pull request Feb 10, 2021
othercodes added a commit that referenced this pull request Feb 10, 2021
* Feature/Added support for key types on Collections. (#12)
* Bugfix/Set mixed as default type for keys in collection. (#13)
* Feature/Domain Event handling improvements. (#14)
* Feature/QueryBus ask methods now has Response as return type. (#15)
* Feature/Added wiki auto-publish action. (#16)
* Feature/Extended documentation. (#17)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant