refactor(scanner)!: Always parse ScanCode license expressions #7331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ac0d5c8 to
6def563
Compare
Remove the feature to toggle parsing of ScanCode license expressions. Starting with ScanCode output format version 3, license expressions are first class citizens in ScanCode results, making this feature cumbersome to maintain. Note that the web-app report still would not show license expressions anyway [1]. [1]: #5017 Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
6def563 to
65ab440
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #7331 +/- ##
=========================================
Coverage 61.15% 61.15%
Complexity 1968 1968
=========================================
Files 335 335
Lines 16489 16489
Branches 2350 2350
=========================================
Hits 10084 10084
Misses 5429 5429
Partials 976 976
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mnonnenmacher
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the feature to toggle parsing of ScanCode license expressions. Starting with ScanCode output format version 3, license expressions are first class citizens in ScanCode results, making this feature cumbersome to maintain.
Note that the web-app report still would not show license expressions anyway (see issue #5017).