Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebApp Reporter: Show the (concluded) license expression that choices are applied on (resulting in the effective license) #5017

Open
MarcelBochtler opened this issue Feb 2, 2022 · 2 comments
Open

WebApp Reporter: Show the (concluded) license expression that choices are applied on (resulting in the effective license) #5017

MarcelBochtler opened this issue Feb 2, 2022 · 2 comments
Labels
enhancement Issues that are considered to be enhancements reporter About the reporter tool

Comments

@MarcelBochtler
Copy link
Member

MarcelBochtler commented Feb 2, 2022 •
edited by sschuberth
Loading

The scan-result.yml contains license findings with a choice for the jhipster package:

- license: "Apache-2.0 OR GPL-1.0-or-later"
  location:
    path: "META-INF/maven/io.github.jhipster/jhipster-framework/pom.xml"
    start_line: 21
    end_line: 24
- license: "Apache-2.0 OR GPL-2.0-or-later WITH Classpath-exception-2.0"
  location:
    path: "META-INF/maven/io.github.jhipster/jhipster-framework/pom.xml"
    start_line: 18
    end_line: 21

The WebApp reporter does not display these license choices:
SCR-20220202-nzp
@MarcelBochtler MarcelBochtler added the reporter About the reporter tool label Feb 2, 2022
@tsteenbe
Copy link
Member

tsteenbe commented Feb 3, 2022

@MarcelBochtler The WebApp reporter may show the real issue is that the EvaluatedModel is still using LicenseId instead of SpdxExpression.

@sschuberth sschuberth mentioned this issue Jul 19, 2023
Closed
sschuberth added a commit that referenced this issue Jul 25, 2023
@sschuberth
refactor(scanner)!: Always parse ScanCode license expressions
ac0d5c8 
Remove the feature to toggle parsing of ScanCode license expressions.
Starting with ScanCode output format verion 3, license expressions are
first class citizens in ScanCode results, making this feature cumbersome
to maintain.

Note that the web-app report still would not show license expressions
anyway (see issue #5017).

Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
@sschuberth sschuberth mentioned this issue Jul 25, 2023
Merged
sschuberth added a commit that referenced this issue Jul 25, 2023
@sschuberth
refactor(scanner)!: Always parse ScanCode license expressions
6def563 
Remove the feature to toggle parsing of ScanCode license expressions.
Starting with ScanCode output format version 3, license expressions are
first class citizens in ScanCode results, making this feature cumbersome
to maintain.

Note that the web-app report still would not show license expressions
anyway (see issue #5017).

Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
sschuberth added a commit that referenced this issue Jul 25, 2023
@sschuberth
refactor(scanner)!: Always parse ScanCode license expressions
65ab440 
Remove the feature to toggle parsing of ScanCode license expressions.
Starting with ScanCode output format version 3, license expressions are
first class citizens in ScanCode results, making this feature cumbersome
to maintain.

Note that the web-app report still would not show license expressions
anyway [1].

[1]: #5017

Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
sschuberth added a commit that referenced this issue Aug 21, 2023
@sschuberth
refactor(scanner)!: Always parse ScanCode license expressions
10bf84c 
Remove the feature to toggle parsing of ScanCode license expressions.
Starting with ScanCode output format version 3, license expressions are
first class citizens in ScanCode results, making this feature cumbersome
to maintain.

Note that the web-app report still would not show license expressions
anyway [1].

[1]: #5017

Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
@sschuberth
Copy link
Member

More generally, we should make it easy for users of the web-app report to copy & paste the concluded license (that might still contain a choice) to a license choice configuration in order to tweak the effective license (/cc @mmurto). I'll adapt the issue title accordingly.

@sschuberth sschuberth changed the title WebApp Reporter: License expressions from ScanCode should be displayed in report WebApp Reporter: Show the (concluded) license expression that choices are applied on (resulting in the effective license) May 15, 2024
@sschuberth sschuberth added the enhancement Issues that are considered to be enhancements label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Issues that are considered to be enhancements reporter About the reporter tool
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sschuberth @tsteenbe @MarcelBochtler