Fix style issues in uav drag launch files #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjcarroll
approved these changes
Jun 9, 2022
iche033
added a commit
that referenced
this pull request
Jun 20, 2022
…lock (#108) * Adds a simple demo with multiple robots lifting the same overweight block. > Note: Not sure if we really should be keeping this stuff in `mbzir_ign` or we should have a `mbzirc_demos` package. This demo demonstrates using multiple robots to lift the same overweight block. Requires gazebosim/gz-physics#345 ## To Test Make sure you have the right branch of gz-physics set up. Launch the test world file: ```bash ign gazebo /your/path/to/mbzirc_ws/src/mbzirc/mbzirc_ign/worlds/test/multi_drone_lift.sdf ``` In another terminal run: ```bash ros2 launch mbzirc_ign multi_uav_lift_demo.launch.py ``` You should see the drones spawn. After that run the simulators and let the robots fall onto the block. When the robots are resting on the block run: ```bash ros2 run mbzirc_ign multi_uav_demo.py ``` Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org> * Address PR Feedback Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org> * fix spawn multi uav Signed-off-by: Ian Chen <ichen@osrfoundation.org> * fix params Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org> * Add the test worlds Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org> * more test stuff Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org> * Added new large models for dragging into testing world, launch scripts for dragging Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Cleaning up additional flat scenario on the roof Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * fix style (#141) Signed-off-by: Ian Chen <ichen@osrfoundation.org> * Create unique gripper model per parent vehicle model (#143) * create unique gripper model files per uav Signed-off-by: Ian Chen <ichen@osrfoundation.org> * style Signed-off-by: Ian Chen <ichen@osrfoundation.org> * Checking if gipper model name is a substring instead of direct compare (#145) Signed-off-by: Aaron Chong <aaronchongth@gmail.com> Co-authored-by: Aaron Chong <aaronchongth@gmail.com> * fix style Signed-off-by: Ian Chen <ichen@osrfoundation.org> * fix spawning uav without gripper Signed-off-by: Ian Chen <ichen@osrfoundation.org> * fixing tests Signed-off-by: Ian Chen <ichen@osrfoundation.org> * Updating doc in example lift and drag demos, adding detach flag in demo script Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Clean up ununsed demo launch file Signed-off-by: Aaron Chong <aaronchongth@gmail.com> Co-authored-by: Ian Chen <ichen@osrfoundation.org> Co-authored-by: Aaron Chong <aaronchongth@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ian Chen ichen@osrfoundation.org