Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish tf_static with transient_local durability #64

Merged
merged 2 commits into from
Jun 21, 2022

Conversation

chapulina
Copy link
Contributor

Tracking down the issue

@quarkytale , I figured out what the tf_static issue was. It turns out it's a QoS mismatch. I found out because when I tried to view TF with

ros2 run tf2_tools view_frames

I'd see a message saying

[WARN] [1655778779.765880584] [view_frames]: New publisher discovered on topic '/tf_static', offering incompatible QoS. No messages will be received from it. Last incompatible policy: DURABILITY

Then with the following, I saw that the subscriber was expecting TRANSIENT_LOCAL durability (i.e. latched message)

ros2 topic info /tf_static -v

Changes

  • Override the durability for the tf_static topic using a parameter on the launch file. That requires #259 to be merged upstream.
  • Remove the static transform that was filling the gap so far
  • Depend on ros_ign_bridge - that helps when building in a colcon workspace, and should also help CI / releasing
  • Reduce the static publish frequency to 1 Hz (it defaults to 50Hz), because that doesn't change anyway
  • Use the model frame MBARI_WEC instead of the canonical link frame MBARI_WEC/Buoy for odom. That's the proper frame to use, because in the future we may add an offset between these 2.

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina requested a review from quarkytale June 21, 2022 02:56
@chapulina chapulina self-assigned this Jun 21, 2022
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Copy link
Contributor

@quarkytale quarkytale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this!

@quarkytale quarkytale merged commit 054230c into quarkytale/rviz Jun 21, 2022
@quarkytale quarkytale deleted the chapulina/tf_static branch June 21, 2022 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants