Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: set QoS options to override durability (#250) #259

Merged
merged 1 commit into from
Jun 21, 2022

Conversation

chapulina
Copy link
Contributor

@chapulina chapulina commented Jun 21, 2022

🎉 New feature

Summary

For future reference, this is necessary when bridging tf_static, because it expects a transient_local durability. We're planning to open a separate PR with a demo for how to do this, but here's an example:

      bridge = Node(
          package='ros_ign_bridge',
          executable='parameter_bridge',
          arguments=[
              # Bridge static poses from PosePublisher
              '/model/' + model_name + '/pose_static@tf2_msgs/msg/TFMessage[ignition.msgs.Pose_V',
          ],
          remappings=[
              # Remap to tf_static
              ('/model/' + model_name + '/pose_static', '/tf_static'),
          ],
         # Set correct durability for tf_static
          parameters=[{'qos_overrides./tf_static.publisher.durability' : 'transient_local'}]
      )

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>

Co-authored-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina added the ROS 2 ROS 2 label Jun 21, 2022
@chapulina chapulina added the MBARI buoy Sponsored by MBARI buoy sim project: https://github.com/osrf/buoy_sim label Jun 21, 2022
@chapulina chapulina requested a review from quarkytale June 21, 2022 02:46
@chapulina chapulina self-assigned this Jun 21, 2022
Copy link
Contributor

@quarkytale quarkytale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

@quarkytale
Copy link
Contributor

I can take up the demo in a separate PR :)

@chapulina chapulina merged commit f0e9a25 into galactic Jun 21, 2022
@chapulina chapulina deleted the chapulina/galactic/250 branch June 21, 2022 15:42
@quarkytale quarkytale mentioned this pull request Jun 24, 2022
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MBARI buoy Sponsored by MBARI buoy sim project: https://github.com/osrf/buoy_sim ROS 2 ROS 2
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants