Update build instructions #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Signed-off-by: Dharini Dutia <dharini@openrobotics.org>
|
@mabelzhang This is ready for review, tested the new image, sim works without any errors on startup. Though note, starting a new terminal using ./join.bash we need to source ~/setup.bash, just setting up the mbari_wec_ws/install/setup.bash won't work. |
mabelzhang
reviewed
Jun 23, 2023
Could you link to that PR in this PR, so we know to update the Dockerfile when that PR is merged? A comment above the block in the Dockerfile linking to that PR, saying the SDF_PATH is not needed after that PR is merged, will also be helpful for anyone wondering what it's for in the future. |
mabelzhang
reviewed
Jun 23, 2023
Signed-off-by: Dharini Dutia <dharini@openrobotics.org>
Signed-off-by: Dharini Dutia <dharini@openrobotics.org>
mabelzhang
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to osrf/mbari_wec_gz#95
Setting an environment variable
SDF_PATHavoids robot_state_publisher showing errors while running the main launch file.Note, this does not affect the sim running by default but throws errors (like in the tagged issue) which can be confusing.
There's an open PR in sdformat_urdf to handle mode:// paths which would be extended to parse package:// paths as well (yet to confirm that). But until then, this step is necessary to run RViz alongside the sim.
Just added it in the build instructions, shall I add it in the
SETUP_SHin the dockerfile as well?