Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python linear damper example tutorial #33

Merged
merged 23 commits into from
Mar 20, 2023
Merged

python linear damper example tutorial #33

merged 23 commits into from
Mar 20, 2023

Conversation

andermi
Copy link
Collaborator

@andermi andermi commented Mar 3, 2023 •
edited
Loading

andermi added 12 commits February 27, 2023 14:01
@andermi
start on cpp template tutorial starting from python version
ac8dbe6 
Signed-off-by: Michael Anderson <anderson@mbari.org>
@andermi
first draft cpp
da4fc65 
Signed-off-by: Michael Anderson <anderson@mbari.org>
@andermi
fix open loop example
147239e 
Signed-off-by: Michael Anderson <anderson@mbari.org>
@andermi
minor
e5d4936 
Signed-off-by: Michael Anderson <anderson@mbari.org>
@andermi
minor
3d55e49 
Signed-off-by: Michael Anderson <anderson@mbari.org>
@andermi
minor
7154137 
Signed-off-by: Michael Anderson <anderson@mbari.org>
@andermi
add packet rates to cpp
64056d5 
Signed-off-by: Michael Anderson <anderson@mbari.org>
@andermi
add packet rates to py
7fea452 
Signed-off-by: Michael Anderson <anderson@mbari.org>
@andermi
add packet rates to py
fe630a2 
Signed-off-by: Michael Anderson <anderson@mbari.org>
@andermi
update links and remove unused file
d50db80 
Signed-off-by: Michael Anderson <anderson@mbari.org>
@andermi
Merge branch 'main' into andermi/external_controller_template_cpp
d340e63
@andermi
python linear damper example tutorial
e0d0425 
Signed-off-by: Michael Anderson <anderson@mbari.org>
@github-actions
Copy link

github-actions bot commented Mar 3, 2023 •
edited
Loading

PR Preview Action v1.3.0
Preview removed because the pull request was closed.
2023-03-20 18:28 UTC

@andermi andermi mentioned this pull request Mar 3, 2023
Closed
4 tasks
@andermi andermi linked an issue Mar 3, 2023 that may be closed by this pull request
Create Controller Tutorials #27
Closed
4 tasks
andermi added 3 commits March 2, 2023 21:28
@andermi
formatting
d193ddd 
Signed-off-by: Michael Anderson <anderson@mbari.org>
@andermi
formatting
daf4e0d 
Signed-off-by: Michael Anderson <anderson@mbari.org>
@andermi
first draft; need to show expected controller output
df83a73 
Signed-off-by: Michael Anderson <anderson@mbari.org>
@andermi andermi force-pushed the andermi/python_linear_damper_tutorial branch from de08072 to df83a73 Compare March 3, 2023 08:47
@andermi
add example controller output
5d22c1f 
Signed-off-by: Michael Anderson <anderson@mbari.org>
@andermi andermi marked this pull request as ready for review March 3, 2023 17:29
@andermi
update line numbers etc after fixing linters in template
20fce16 
Signed-off-by: Michael Anderson <anderson@mbari.org>
quarkytale
quarkytale reviewed Mar 7, 2023
View reviewed changes
Copy link
Contributor

@quarkytale quarkytale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying out the tutorial, will update comments after

docs/docs/Tutorials/ROS2/PythonLinearDamperExample.md Show resolved Hide resolved
docs/docs/Tutorials/ROS2/PythonLinearDamperExample.md Outdated Show resolved Hide resolved
docs/docs/Tutorials/ROS2/PythonLinearDamperExample.md Outdated Show resolved Hide resolved
docs/docs/Tutorials/ROS2/PythonLinearDamperExample.md Outdated Show resolved Hide resolved
andermi and others added 3 commits March 7, 2023 14:57
@andermi @quarkytale
Update docs/docs/Tutorials/ROS2/PythonLinearDamperExample.md
ab8db35 
Co-authored-by: Dharini Dutia <dharini@openrobotics.org>
@andermi @quarkytale
Update docs/docs/Tutorials/ROS2/PythonLinearDamperExample.md
9c06ea5 
Co-authored-by: Dharini Dutia <dharini@openrobotics.org>
@andermi
Update PythonLinearDamperExample.md
0021c7a
Base automatically changed from andermi/external_controller_template_cpp to main March 7, 2023 23:43
quarkytale
quarkytale reviewed Mar 8, 2023
View reviewed changes
Copy link
Contributor

@quarkytale quarkytale left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through it works for me! Just have some rephrasing and formatting suggestions, otherwise LGTM

docs/docs/Tutorials/ROS2/PythonLinearDamperExample.md Outdated Show resolved Hide resolved
docs/docs/Tutorials/ROS2/PythonLinearDamperExample.md Outdated Show resolved Hide resolved
docs/docs/Tutorials/ROS2/PythonLinearDamperExample.md Show resolved Hide resolved
docs/docs/Tutorials/ROS2/PythonLinearDamperExample.md Outdated Show resolved Hide resolved
andermi and others added 3 commits March 17, 2023 16:45
@andermi @quarkytale
Update docs/docs/Tutorials/ROS2/PythonLinearDamperExample.md
31fec7a 
Co-authored-by: Dharini Dutia <dharini@openrobotics.org>
@andermi
PR comments
a9641ad 
Signed-off-by: Michael Anderson <anderson@mbari.org>
@andermi
Merge branch 'main' into andermi/python_linear_damper_tutorial
0d1f1b9 
Signed-off-by: Michael Anderson <anderson@mbari.org>
@andermi andermi requested a review from quarkytale March 17, 2023 21:43
@andermi andermi merged commit 05786a8 into main Mar 20, 2023
@andermi andermi deleted the andermi/python_linear_damper_tutorial branch March 20, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quarkytale quarkytale quarkytale approved these changes

@hamilton8415 hamilton8415 Awaiting requested review from hamilton8415

@mabelzhang mabelzhang Awaiting requested review from mabelzhang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Controller Tutorials
2 participants
@andermi @quarkytale