Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-declare some symbols to accomodate julia nightly #4580

Closed
wants to merge 4 commits into from

Conversation

fieker
Copy link
Contributor

@fieker fieker commented Feb 12, 2025

No description provided.

@lgoettgens lgoettgens added nightly error with julia nightly or pre-releases experimental Only changes experimental parts of the code release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes labels Feb 12, 2025
@lgoettgens
Copy link
Member

I think you have to do the exact same thing for factor_set as well.

@lgoettgens lgoettgens changed the title add indecomposition as a symbol Pre-declare some symbols to accomodate julia nightly Feb 12, 2025
@lgoettgens
Copy link
Member

Hmm, this seems to not have changed anything compared to master considering the error logs. @benlorenz any other idea? I'll have a look later today as well

@benlorenz
Copy link
Member

benlorenz commented Feb 13, 2025

Hmm, this seems to not have changed anything compared to master considering the error logs. @benlorenz any other idea? I'll have a look later today as well

I think both need to be added to one of the import statements at the top of GaloisCohomology.jl.

@lgoettgens
Copy link
Member

I found a different solution to the problem that involves less overhead with pre-declarations of functions stubs etc, see #4588

@fieker
Copy link
Contributor Author

fieker commented Feb 13, 2025 via email

@lgoettgens
Copy link
Member

On Thu, Feb 13, 2025 at 03:24:53AM -0800, Lars Göttgens wrote: I found a different solution to the problem that involves less overhead with pre-declarations of functions stubs etc, see #4588
Very good = is there an explanation or is this try-and-error?

See #4588 (comment) for a try to explain this.

@lgoettgens lgoettgens deleted the indecomposition4nightly branch February 13, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
experimental Only changes experimental parts of the code nightly error with julia nightly or pre-releases release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants