Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve oras manifest fetch --platform error message #330

Merged
merged 2 commits into from
Sep 22, 2022

Conversation

lizMSFT
Copy link
Contributor

@lizMSFT lizMSFT commented Sep 22, 2022

Resolves: oras-project/oras#600

Signed-off-by: Zoey Li zoeyli@microsoft.com

@lizMSFT lizMSFT force-pushed the liz/600 branch 2 times, most recently from 88edbff to d233b9e Compare September 22, 2022 05:11
@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2022

Codecov Report

Merging #330 (e0be0af) into main (8ad5a24) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #330   +/-   ##
=======================================
  Coverage   72.42%   72.42%           
=======================================
  Files          38       38           
  Lines        3615     3615           
=======================================
  Hits         2618     2618           
  Misses        738      738           
  Partials      259      259           
Impacted Files Coverage Δ
internal/platform/platform.go 81.42% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Zoey Li <zoeyli@microsoft.com>
Signed-off-by: Zoey Li <zoeyli@microsoft.com>
Copy link
Member

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 2b4088e into oras-project:main Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve oras manifest fetch --platform error message
5 participants