fix: improve oras manifest fetch --platform error message

Signed-off-by: Zoey Li <zoeyli@microsoft.com>
oras-project · Sep 22, 2022 · cb89654 · cb89654
1 parent 8ad5a24
commit cb89654
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/copy_test.go b/copy_test.go
@@ -978,7 +978,7 @@ func TestCopy_WithTargetPlatformOptions(t *testing.T) {
 	}
 
 	_, err = oras.Copy(ctx, src, ref, dst, "", opts)
-	expected = fmt.Sprintf("mismatch MediaType %s: expect %s", docker.MediaTypeConfig, ocispec.MediaTypeImageConfig)
+	expected = fmt.Sprintf("fail to recognize media type %s: expect %s", docker.MediaTypeConfig, ocispec.MediaTypeImageConfig)
 	if err.Error() != expected {
 		t.Fatalf("Copy() error = %v, wantErr %v", err, expected)
 	}

diff --git a/internal/platform/platform.go b/internal/platform/platform.go
@@ -118,7 +118,7 @@ func SelectManifest(ctx context.Context, src content.ReadOnlyStorage, root ocisp
 // fields in config blob.
 func getPlatformFromConfig(ctx context.Context, src content.ReadOnlyStorage, desc ocispec.Descriptor, targetConfigMediaType string) (*ocispec.Platform, error) {
 	if desc.MediaType != targetConfigMediaType {
-		return nil, fmt.Errorf("mismatch MediaType %s: expect %s", desc.MediaType, targetConfigMediaType)
+		return nil, fmt.Errorf("fail to recognize media type %s: expect %s", desc.MediaType, targetConfigMediaType)
 	}
 
 	rc, err := src.Fetch(ctx, desc)

diff --git a/internal/platform/platform_test.go b/internal/platform/platform_test.go
@@ -291,7 +291,7 @@ func TestSelectManifest(t *testing.T) {
 		OS:           os_1,
 	}
 	_, err = SelectManifest(ctx, storage, root, &targetPlatform)
-	expected = fmt.Sprintf("mismatch MediaType %s: expect %s", docker.MediaTypeConfig, ocispec.MediaTypeImageConfig)
+	expected = fmt.Sprintf("fail to recognize media type %s: expect %s", docker.MediaTypeConfig, ocispec.MediaTypeImageConfig)
 	if err.Error() != expected {
 		t.Fatalf("SelectManifest() error = %v, wantErr %v", err, expected)
 	}