Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes last clutter from zipkin startup #3240

Merged
merged 1 commit into from
Oct 16, 2020
Merged

Removes last clutter from zipkin startup #3240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions zipkin-server/src/main/resources/simplelogger.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,8 @@ org.slf4j.simpleLogger.showShortLogName=true
# This only includes Armeria as for example Kafka and Cassandra are not in the slim dist
org.slf4j.simpleLogger.log.com.linecorp.armeria.client.HttpResponseDecoder=OFF
org.slf4j.simpleLogger.log.com.linecorp.armeria.common.Flags=OFF
org.slf4j.simpleLogger.log.com.linecorp.armeria.server.docs.DocStringExtractor=OFF
org.slf4j.simpleLogger.log.com.linecorp.armeria.spring.ArmeriaAutoConfiguration=WARN
org.slf4j.simpleLogger.log.com.linecorp.armeria.common.util.SystemInfo=WARN
org.slf4j.simpleLogger.log.com.linecorp.armeria.internal.common.JavaVersionSpecific=OFF
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the logger that keeps saying we are Java 9+ :)

org.slf4j.simpleLogger.log.com.linecorp.armeria.server.docs.DocService=OFF
org.slf4j.simpleLogger.log.com.linecorp.armeria.internal.common.thrift.ThriftSerializationFormatProvider=OFF

org.slf4j.simpleLogger.log.com.linecorp.armeria.server.docs.DocStringExtractor=OFF
org.slf4j.simpleLogger.log.com.linecorp.armeria.spring.ArmeriaAutoConfiguration=WARN
7 changes: 4 additions & 3 deletions zipkin-server/src/main/resources/zipkin-server-shared.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,13 +267,14 @@ logging:
# logging when enabled. https://github.com/line/armeria/issues/2000
com.linecorp.armeria.client.HttpResponseDecoder: 'OFF'
com.linecorp.armeria.common.Flags: 'OFF'
com.linecorp.armeria.common.SerializationFormat: 'OFF'
# Hostname logging is not Zipkin's duty
com.linecorp.armeria.common.util.SystemInfo: 'WARN'
com.linecorp.armeria.internal.common.JavaVersionSpecific: 'OFF'
com.linecorp.armeria.server.docs.DocStringExtractor: 'OFF'
com.linecorp.armeria.server.docs.DocService: 'OFF'
com.linecorp.armeria.internal.common.thrift.ThriftSerializationFormatProvider: 'OFF'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this wasn't the right one com.linecorp.armeria.common.SerializationFormat was.. (until that gets muted upstream)

# Redundant to logging already done in c.l.a.s.Server
com.linecorp.armeria.spring.ArmeriaAutoConfiguration: 'WARN'
# Hostname logging is not Zipkin's duty
com.linecorp.armeria.common.util.SystemInfo: 'WARN'
# kafka is quite chatty so we switch everything off by default
org.apache.kafka: 'OFF'
# # investigate /api/v2/dependencies
Expand Down