Removes last clutter from zipkin startup #3240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| org.slf4j.simpleLogger.log.com.linecorp.armeria.common.util.SystemInfo=WARN | ||
| org.slf4j.simpleLogger.log.com.linecorp.armeria.internal.common.JavaVersionSpecific=OFF |
There was a problem hiding this comment.
this is the logger that keeps saying we are Java 9+ :)
| com.linecorp.armeria.server.docs.DocStringExtractor: 'OFF' | ||
| com.linecorp.armeria.server.docs.DocService: 'OFF' | ||
| com.linecorp.armeria.internal.common.thrift.ThriftSerializationFormatProvider: 'OFF' |
There was a problem hiding this comment.
this wasn't the right one com.linecorp.armeria.common.SerializationFormat was.. (until that gets muted upstream)
There was some difference between lens and the full dist. Regardless, we don't need to log every time that we are using Java 9+.
2936acf to
7fded2b
Compare
jorgheymans
approved these changes
Oct 16, 2020
mauriziocescon
added a commit
to mauriziocescon/zipkin
that referenced
this pull request
Nov 16, 2020
* 2_22_0: (108 commits) [maven-release-plugin] prepare release 2.22.0 Hardens integration tests, fixes small bug (openzipkin#3258) Deprecates Cassandra v1 schema for removal in Zipkin 2.23 (openzipkin#3254) Update Armeria to 1.2.0 and Netty to 4.1.53 (openzipkin#3257) Removes JMX dependency from our docker configuration (openzipkin#3252) Quiets startup logging (openzipkin#3253) Removes Cassandra querybuilder dependency (openzipkin#3250) Migrates to Datastax Driver v4 (openzipkin#3246) Refactors integration tests to be more isolated (openzipkin#3249) Adds workaround to missed decorator route (openzipkin#3245) disallow trace requests (openzipkin#3239) Refactors Cassandra queries so they are cheaper and easier to migrate (openzipkin#3243) fix docker hook CWD Builds builder with same script as other images (openzipkin#3242) Removes last clutter from zipkin startup (openzipkin#3240) Stops docker-compose from being mistaken as a workflow (openzipkin#3241) fix master Finishes Docker refactoring (openzipkin#3238) Bumps versions and applies failsafe workaround (openzipkin#3235) Fix a bug in the unit of duration (openzipkin#3234) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was some difference between lens and the full dist. Regardless, we
don't need to log every time that we are using Java 9+.