Add missing dependencies to ./copy-builtin #854
Conversation
ZFS depends on EFI_PARTITION, ZLIB_DEFLATE and ZLIB_INFLATE, but when ZFS is integrated with the kernel source tree, menuconfig does not enforce these dependencies. This can cause build failures in the case of ZLIB_DEFLATE and ZLIB_INFLATE where symbols are not found. This can also cause runtime failures in the case of EFI_PARTITION, where the kernel will not understand GPT partitions when creating pools from raw disks. We solve this by making menuconfig aware of these dependencies. Signed-off-by: Richard Yao <ryao@cs.stonybrook.edu>
|
If I understand this correctly, if the kernel doesn't have the necessary features, in-tree compilation will fail. Does out-of-tree compilation fail too, and if not, why? |
|
Many distributions build with ZLIB_DEFLATE and ZLIB_INFLATE as modules which would be OK for an out of tree compilation. However, I image this would be fatal for an in-tree compilation unless CONFIG_ZFS was also being built as a module. |
|
Although... the ZLIB_* dependencies perhaps more correctly belong with the spl module. And it wouldn't be a bad idea to add a configure check to ensure your kernel was built with EFI_PARTITION since we rely on it, |
|
@behlendorf An EFI_PARTITION check would close issue #489. The ZLIB_DEFLATE and ZLIB_INFLATE checks are issue #582. Gentoo's package manager can be configured to do these checks before the ./configure script is run by defining a single variable in the ebuild. As a result, I have had zero motivation to implement them in autotools. |
|
Yeah, I don't blame you. There are only so many hours in the day. Anyway, thanks for the patch as is. I can pull the ZLIB bits in to the spl and leave the EFI_PARTITION in the zfs code after a little testing. |
|
Merged as commit 9a512dc |
ZFS depends on EFI_PARTITION, ZLIB_DEFLATE and ZLIB_INFLATE, but when
ZFS is integrated with the kernel source tree, menuconfig does not
enforce these dependencies. This can cause build failures in the case of
ZLIB_DEFLATE and ZLIB_INFLATE where symbols are not found. This can also
cause runtime failures in the case of EFI_PARTITION, where the kernel
will not understand GPT partitions when creating pools from raw disks.
We solve this by making menuconfig aware of these dependencies.
Signed-off-by: Richard Yao ryao@cs.stonybrook.edu