Skip to content

Commit

Permalink
Add missing dependencies to ./copy-builtin
Browse files Browse the repository at this point in the history
ZFS depends on EFI_PARTITION, ZLIB_DEFLATE and ZLIB_INFLATE, but when
ZFS is integrated with the kernel source tree, menuconfig does not
enforce these dependencies. This can cause build failures in the case of
ZLIB_DEFLATE and ZLIB_INFLATE where symbols are not found. This can also
cause runtime failures in the case of EFI_PARTITION, where the kernel
will not understand GPT partitions when creating pools from raw disks.
We solve this by making menuconfig aware of these dependencies.

Signed-off-by: Richard Yao <ryao@cs.stonybrook.edu>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #854
  • Loading branch information
ryao authored and behlendorf committed Aug 6, 2012
1 parent 7c0e570 commit 9a512dc
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions copy-builtin
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,9 @@ cat > "$KERNEL_DIR/fs/zfs/Kconfig" <<"EOF"
config ZFS
tristate "ZFS"
depends on SPL
depends on EFI_PARTITION
select ZLIB_INFLATE
select ZLIB_DEFLATE
help
This is the ZFS filesystem from the ZFS On Linux project.
Expand Down

0 comments on commit 9a512dc

Please sign in to comment.