Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

offensive strings in dnode.h #8698

Closed
fixyourcodeplease opened this issue May 1, 2019 · 7 comments
Closed

offensive strings in dnode.h #8698

fixyourcodeplease opened this issue May 1, 2019 · 7 comments
Assignees

Comments

@fixyourcodeplease
Copy link

/*
 * There should be a ## between the string literal and fmt, to make it
 * clear that we're joining two strings together, but that piece of shit
 * gcc doesn't support that preprocessor token.
 */

as a contributor to GCC, this is highly offensive. we should look into some consequences for this, thanks to the new CoC.

@ahrens
Copy link
Member

ahrens commented May 1, 2019

I agree, let's adjust the language here.

If you'd like to report a code of conduct violation, please email conduct@open-zfs.org. Here are the reporting guidelines: http://www.open-zfs.org/wiki/Reporting_Guide

@ahrens ahrens self-assigned this May 1, 2019
@fixyourcodeplease
Copy link
Author

consider this the report, I do not wish to email my name, address and contact number to anyone.

@ahrens
Copy link
Member

ahrens commented May 1, 2019

FYI, you do not need to provide that information, you may report anonymously. From the Reporting Guide:

You may report incidents anonymously if you are uncomfortable providing your contact information.

ahrens added a commit to ahrens/zfs that referenced this issue May 1, 2019
This comment seems to misunderstand the ## preprocessor token, which
does token concatenation.  It is not needed here, since we are
concatenating string literals, which is performed by putting the
literals next to each other.

Additionally, the comment uses offensive language.

Signed-off-by: Matthew Ahrens <mahrens@delphix.com>
Closes openzfs#8698
@fixyourcodeplease
Copy link
Author

okay, how does one send an anonymous email?

@ahrens
Copy link
Member

ahrens commented May 1, 2019

@fixyourcodeplease
Copy link
Author

ok, thank you! the privacy of those seem dubious but I will take their word for it.

I feel empowered to contribute to your project thanks to the CoC. I have been looking through commit messages and source code and I see many changes to make over the next few months. thank you for being understanding.

@ahrens
Copy link
Member

ahrens commented May 2, 2019

FYI, the (now removed) comment in question was part of the original ZFS commit to OpenSolaris in 2005. So we can't determine who wrote it originally.

allanjude pushed a commit to allanjude/zfs that referenced this issue Jun 7, 2019
This comment seems to misunderstand the ## preprocessor token, which
does token concatenation.  It is not needed here, since we are
concatenating string literals, which is performed by putting the
literals next to each other.

Additionally, the comment uses offensive language.

Reviewed-by: Igor Kozhukhov <igor@dilos.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Tony Nguyen <tony.nguyen@delphix.com>
Signed-off-by: Matthew Ahrens <mahrens@delphix.com>
Closes openzfs#8698
Closes openzfs#8699
allanjude pushed a commit to allanjude/zfs that referenced this issue Jun 15, 2019
This comment seems to misunderstand the ## preprocessor token, which
does token concatenation.  It is not needed here, since we are
concatenating string literals, which is performed by putting the
literals next to each other.

Additionally, the comment uses offensive language.

Reviewed-by: Igor Kozhukhov <igor@dilos.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Tony Nguyen <tony.nguyen@delphix.com>
Signed-off-by: Matthew Ahrens <mahrens@delphix.com>
Closes openzfs#8698
Closes openzfs#8699
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants