-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
offensive strings in dnode.h #8698
Comments
I agree, let's adjust the language here. If you'd like to report a code of conduct violation, please email conduct@open-zfs.org. Here are the reporting guidelines: http://www.open-zfs.org/wiki/Reporting_Guide |
consider this the report, I do not wish to email my name, address and contact number to anyone. |
FYI, you do not need to provide that information, you may report anonymously. From the Reporting Guide:
|
This comment seems to misunderstand the ## preprocessor token, which does token concatenation. It is not needed here, since we are concatenating string literals, which is performed by putting the literals next to each other. Additionally, the comment uses offensive language. Signed-off-by: Matthew Ahrens <mahrens@delphix.com> Closes openzfs#8698
okay, how does one send an anonymous email? |
I'm not an expert in that, but here are the first 4 google results for "anonymous email": https://www.pcmag.com/article/331733/how-to-create-an-anonymous-email-account |
ok, thank you! the privacy of those seem dubious but I will take their word for it. I feel empowered to contribute to your project thanks to the CoC. I have been looking through commit messages and source code and I see many changes to make over the next few months. thank you for being understanding. |
FYI, the (now removed) comment in question was part of the original ZFS commit to OpenSolaris in 2005. So we can't determine who wrote it originally. |
This comment seems to misunderstand the ## preprocessor token, which does token concatenation. It is not needed here, since we are concatenating string literals, which is performed by putting the literals next to each other. Additionally, the comment uses offensive language. Reviewed-by: Igor Kozhukhov <igor@dilos.org> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Tony Nguyen <tony.nguyen@delphix.com> Signed-off-by: Matthew Ahrens <mahrens@delphix.com> Closes openzfs#8698 Closes openzfs#8699
This comment seems to misunderstand the ## preprocessor token, which does token concatenation. It is not needed here, since we are concatenating string literals, which is performed by putting the literals next to each other. Additionally, the comment uses offensive language. Reviewed-by: Igor Kozhukhov <igor@dilos.org> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Tony Nguyen <tony.nguyen@delphix.com> Signed-off-by: Matthew Ahrens <mahrens@delphix.com> Closes openzfs#8698 Closes openzfs#8699
as a contributor to GCC, this is highly offensive. we should look into some consequences for this, thanks to the new CoC.
The text was updated successfully, but these errors were encountered: