Skip to content

Commit

Permalink
Remove incorrect (and inappropriate) comment in dprintf_dnode
Browse files Browse the repository at this point in the history
This comment seems to misunderstand the ## preprocessor token, which
does token concatenation.  It is not needed here, since we are
concatenating string literals, which is performed by putting the
literals next to each other.

Additionally, the comment uses offensive language.

Reviewed-by: Igor Kozhukhov <igor@dilos.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Tony Nguyen <tony.nguyen@delphix.com>
Signed-off-by: Matthew Ahrens <mahrens@delphix.com>
Closes openzfs#8698
Closes openzfs#8699
  • Loading branch information
ahrens authored and allanjude committed Jun 15, 2019
1 parent 3355209 commit 5832d99
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions include/sys/dnode.h
Original file line number Diff line number Diff line change
Expand Up @@ -589,11 +589,6 @@ extern dnode_stats_t dnode_stats;

#ifdef ZFS_DEBUG

/*
* There should be a ## between the string literal and fmt, to make it
* clear that we're joining two strings together, but that piece of shit
* gcc doesn't support that preprocessor token.
*/
#define dprintf_dnode(dn, fmt, ...) do { \
if (zfs_flags & ZFS_DEBUG_DPRINTF) { \
char __db_buf[32]; \
Expand Down

0 comments on commit 5832d99

Please sign in to comment.