"zfs snapshot" should comply with "ZFS Component Naming Requirements"

[mailinglists35]

According to "Oracle Solaris ZFS Administration Guide" -> "ZFS Component Naming Requirements"*, zfs datasets and pools have restrictions regarding naming. I was able to enter a space character to "zfs snapshot" dataset name (with zfs snapshot testpool@"$date"), thus the resulting snapshot being inaccessible:
"Oct 9 16:12:23 homerouter kernel: [1231221.422106] ZFS: Unable to automount testpool@Tue Oct 9 16:12:00 EEST 2012 at /mnt/testpool/.zfs/snapshot/Tue Oct 9 16:12:00 EEST 2012: 256"

• http://docs.oracle.com/cd/E19253-01/819-5461/gbcpt/index.html

[behlendorf]

Actually this has come up before, see issue #439. At the time it was decided that spaces were permissible because the code explicitly allows it and at the time I wasn't aware of the above documentation you just referenced.

Now as for the automount code failing due to the space, that's a bug. We'll want to update that code to quote the dataset name in the mount command which I expect will resolve the issue.

[mailinglists35]

I wasn't aware either, I just googled to find the specs when the kernel warned about being unable to automount.
If it's decided to broaden the permitted chars, what happens when someone tries to import the pool into a native solaris box? :)

[behlendorf]

@mailinglists35 We didn't broaden the permitted character set, we just used what was already in the code which we originally got from Solaris. So while their documentation says one thing, their code should handle it just fine if properly quoted.